Repository navigation
fix: missing $schema is explicitely Data Package v1 - #1857
Merged
Merged
Conversation
…children Per the spec, a descriptor without `$schema` is an explicit v1, imposed top-down on all children (whose own `$schema` is ignored); a standalone field stays version-less and only inherits. All version gates (name pattern, object missingValues, exclusive bounds) now behave the same for an absent `$schema` as for a declared v1. The resolved version is stored privately on Resource/Schema at import and threaded through from_descriptor/to_copy/validate, so detached children (per-resource validation, copies, transform pipelines) keep the information. exports stay canonical : the export of a child does _not_ create a standalone version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the spec, a descriptor without
$schemais an explicit v1, imposed top-down on all children (whose own$schemais ignored); a standalone field stays version-less and only inherits.All version gates (name pattern, object missingValues, exclusive bounds) now behave the same for an absent
$schemaas for a declared v1.The resolved version is stored privately on Resource/Schema at import and threaded through from_descriptor/to_copy/validate, so detached children (per-resource validation, copies, transform pipelines) keep the information. Exports stay canonical : the export of a child does not create a standalone version.
Also adds an
upgrademethod to upgrade an object from DPv1 to DPv2.Finally, a documentation page has been added to explicit these design choices.