Repository navigation
Drop crate versions from the third-party license file - #477
Conversation
The generated license file listed every crate with its exact version, so every Rust patch bump made it stale and failed the license policy check on each Renovate PR. Versions are not required by any of the licenses we redistribute, and Cargo.lock already records them per release. The file now only changes when a crate enters or leaves the dependency graph or its license text changes. The about.toml allow-list gate is unchanged.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The license document now omits crate versions as intended, and its generated content matches the template change. No material merge risk remains. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: removing crate versions from the third-party license file. |
| Description check | |
The description directly explains the changes, their purpose, affected files, related pull requests, and reported verification results. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Merging this PR will not alter performance
|
There was a problem hiding this comment.
🟢 Approval recommended
The template and regenerated output are consistent, while existing CI continues validating license policy and freshness.
0 open findings
What changed in this PR
Removes crate versions from generated third-party license listings to prevent patch-only dependency updates from creating unnecessary license diffs.
Changes:
- Updates the cargo-about template to display crate names without versions.
- Regenerates the license inventory accordingly.
| File | Description |
|---|---|
about.hbs |
Omits crate versions from generated links. |
THIRD_PARTY_LICENSES.md |
Applies the new versionless format. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Breaking change
None
Proposed change
THIRD_PARTY_LICENSES.mdlisted every crate with its exact version. That made every Rust patch bump stale the file and fail the "Third-party license policy" check on each Renovate PR (currently #474 and #390), which also blocks their automerge.This drops
{{crate.version}}fromabout.hbsand regenerates the file. None of the licenses we redistribute require a version, andCargo.lockalready records them per release.The file now only changes when a crate enters or leaves the dependency graph, or a crate changes its license text. Those are exactly the cases worth a human look. The
about.tomlallow-list gate is unchanged: a crate with a non-allowed license still failscargo about generate.Verified by regenerating the file against the
Cargo.lockof #474 and #390: the output is byte-identical to this branch, so both go green once Renovate rebases them.Type of change
Additional information
Checklist
uv run pytestpasses locally. A pull request cannot be merged unless CI is green.uv run ruff check .anduv run ruff format --check .pass.cargo fmt --checkandcargo clippy --all-targets -- -D warningspass.If the change is user-facing:
docs/is added or updated, anddocs/verify_examples.pystill passes.