feat: reapply MessageOrigin API and remove ApplicationMessage.app#3542
Merged
feat: reapply MessageOrigin API and remove ApplicationMessage.app#3542
Conversation
Contributor
|
After reading all rule files and the complete diff, here is the review: ✅ Rule Review: No issues foundRules checked: No rule violations detected — merge is not blocked by this check. Summary of changes reviewed: This PR is a rename/refactor across the codebase:
Checks performed:
Automated review against |
iduartgomez
added a commit
that referenced
this pull request
Mar 13, 2026
The antiflood-tokens and identity-management module delegates were still using the old `attested: Option<&'static [u8]>` parameter and `ApplicationMessage::new(app, payload)` constructor from freenet-stdlib 0.1.24. This completes the migration started in PR #3542. - antiflood-tokens: upgrade to freenet-stdlib 0.3.1, remove `app` parameter from `allocate_token()`, replace removed GetSecretResponse/ GetSecretRequest match arms with wildcard - identity-management: upgrade to freenet-stdlib 0.3.1, rewrite process() to use V2 host functions (ctx.get_secret/set_secret) instead of the old request/response secret pattern, fix rand_core version conflict by pinning rand to 0.8 - delegate_api.rs: update stale pseudocode examples from `attested` to `origin` Closes #1498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Re-applies #3538 (Nacho's delegate API cleanup), which was temporarily reverted in 3d481af to unblock a regression fix release for v0.1.183 connection instability.
Prerequisites before merging
Original PR
All changes are identical to #3538:
DelegateInterface::process:attested: Option<&'static [u8]>→origin: Option<MessageOrigin>ApplicationMessage: removedapp: ContractInstanceIdfieldApplicationMessage::new(app, payload)→ApplicationMessage::new(payload)This is a breaking change for existing delegate WASM — old delegates cannot be loaded after this lands.
[AI-assisted - Claude]