This repository was archived by the owner on Jul 4, 2025. It is now read-only.
Исправить ошибку получения errorMessages в форме без label#8
Merged
sychova-fh merged 1 commit intotrunkfrom Jan 20, 2025
Merged
Исправить ошибку получения errorMessages в форме без label#8sychova-fh merged 1 commit intotrunkfrom
sychova-fh merged 1 commit intotrunkfrom
Conversation
sychova-fh
requested review from
TheMY3 and
roman-bieliaiev
and removed request for
TheMY3
roman-bieliaiev
approved these changes
Jan 20, 2025
| $label = $elem->getData()['label']; | ||
| $label = is_array($label) ? $label[0] : $label; | ||
| $elementData = $elem->getData(); | ||
| $label = is_array($elementData) && array_key_exists('label', $elementData) ? $elementData['label'] : ''; |
There was a problem hiding this comment.
Suggested change
| $label = is_array($elementData) && array_key_exists('label', $elementData) ? $elementData['label'] : ''; | |
| $label = is_array($elementData) && array_key_exists('label', $elementData) ?? $elementData['label']; |
Возможно и так будет работать. Кажется один из чекеров в проекте такое рекомендует. Не существенно.
Author
There was a problem hiding this comment.
Тут он не подойдет. Если бы было $elementData['label'] ?? '', то можно. А тут проверка один результат имеет, значение - другой
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Задачи Asana
https://app.asana.com/0/534203904994086/1209147915285560/f
Информация
Для открытия модалки с формой при перезагрузке страницы с ошибкой в форме используем errorMessages. Получили не понятную ошибку при использовании. Оказалось, что метод не работает при не установленных label. Лучше исправить в HTML_QuickForm2, чем во всех формах добавлять ненужные label.