Add the ability for plugins to opt-in to asyncronous state calls#310
Open
russellmcc wants to merge 1 commit into
Open
Add the ability for plugins to opt-in to asyncronous state calls#310russellmcc wants to merge 1 commit into
russellmcc wants to merge 1 commit into
Conversation
This adds a new function on state-context that allows the plugin to opt in to receiving save and load calls on a new "state-thread" symbolic thread. Hosts could use this to parallelize loading and saving session state, which can greatly reduce the time it takes to load or save a large session.
Contributor
|
I will propose a different approach which will cover both loading a state or activating the plugin. |
Contributor
|
Here is my proposal: #343 |
Contributor
|
We still need to extend the enum: with a Resource allocations during a project load linked with enumerated unique resources (hardware!) can only safely be restored properly when properly signalled. |
bfe862b to
961be0b
Compare
076ddda to
dbf7513
Compare
533e849 to
50f004f
Compare
de3907e to
c279d5a
Compare
16765e6 to
b16e5f4
Compare
fb5acc0 to
89b761c
Compare
65f58e0 to
3e2c1a5
Compare
c0e3365 to
1e83856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new function on state-context that allows the plugin to opt in to receiving save and load calls on a new "state-thread" symbolic thread. Hosts could use this to parallelize loading and saving session state, which can greatly reduce the time it takes to load or save a large session.
This came out of discussion on #255, and is opened as a PR in the hopes that looking at a concrete change proposal is more productive than discussing in the abstract. I'm happy to reject this and continue the discussion somewhere else if that's more appropriate.
Currently left unaddressed is the idea of activating also on a background thread, raised in this comment. I could use ideas on how to allow this. Perhaps
state-threadis not a good idea and it should be calledbg-threador something like that?