Skip to content

fix: support in/not in filters end to end - #254

Merged
ruchamahabal merged 2 commits into
frappe:developfrom
ruchamahabal:filters
Aug 19, 2026
Merged

fix: support in/not in filters end to end#254
ruchamahabal merged 2 commits into
frappe:developfrom
ruchamahabal:filters

Conversation

@ruchamahabal

@ruchamahabal ruchamahabal commented Aug 19, 2026

Copy link
Copy Markdown
Member

Multi-value filters crashed pages in three ways:

  • the agent emitted flat ["in", "A", "B"] shapes; normalize them to ["in", ["A", "B"]] at the tool boundary and reject other malformed lists with a corrective message
  • getEvaluatedFilters stripped the operator off every [operator, value] filter before fetching, degrading "!=" / "like" to equality and sending in-lists as bare lists ("too many values to unpack"); keep the pair intact and recover legacy flat shapes at fetch time
  • the Edit Data Source dialog had no in/not in operators and silently dropped values from malformed filters; add the operators with proper multi-value inputs (ported from @framework/ui's Filter module: picked options for Select, live record search for Link, comma text otherwise) and lossless de/serialization
image

Multi-value filters crashed pages three ways:
- the agent emitted flat ["in", "A", "B"] shapes; normalize them to
  ["in", ["A", "B"]] at the tool boundary and reject other malformed lists
  with a corrective message
- getEvaluatedFilters stripped the operator off every [operator, value]
  filter before fetching, degrading "!=" / "like" to equality and sending
  in-lists as bare lists ("too many values to unpack"); keep the pair
  intact and recover legacy flat shapes at fetch time
- the Edit Data Source dialog had no in/not in operators and silently
  dropped values from malformed filters; add the operators with proper
  multi-value inputs (ported from @framework/ui's Filter module: picked
  options for Select, live record search for Link, comma text otherwise)
  and lossless de/serialization

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The previously reported nested filter evaluation failure is fixed, and no blocking failure remains.

Reviews (2): Last reviewed commit: "fix: evaluate filter values in array" | Re-trigger Greptile

Comment thread frontend/src/stores/codeStore.ts Outdated
@ruchamahabal
ruchamahabal merged commit defe3b3 into frappe:develop Aug 19, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant