fix: support in/not in filters end to end - #254
Merged
Conversation
Multi-value filters crashed pages three ways:
- the agent emitted flat ["in", "A", "B"] shapes; normalize them to
["in", ["A", "B"]] at the tool boundary and reject other malformed lists
with a corrective message
- getEvaluatedFilters stripped the operator off every [operator, value]
filter before fetching, degrading "!=" / "like" to equality and sending
in-lists as bare lists ("too many values to unpack"); keep the pair
intact and recover legacy flat shapes at fetch time
- the Edit Data Source dialog had no in/not in operators and silently
dropped values from malformed filters; add the operators with proper
multi-value inputs (ported from @framework/ui's Filter module: picked
options for Select, live record search for Link, comma text otherwise)
and lossless de/serialization
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Confidence Score: 5/5The PR appears safe to merge. The previously reported nested filter evaluation failure is fixed, and no blocking failure remains. Reviews (2): Last reviewed commit: "fix: evaluate filter values in array" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-value filters crashed pages in three ways: