fix: scope shared-dep resolver to the frontend dir so the linked frappe-ui checkout can't pull its own @tiptap - #253
Merged
Conversation
…pe-ui checkout can't pull its own @tiptap - With the resolver root at apps/studio, the local frappe-ui checkout counted as 'inside Studio', so its @tiptap imports resolved from frappe-ui/node_modules while studio's own resolved from frontend/node_modules. The dep optimizer then bundled two prosemirror graphs (view 1.41.8 + 1.42.2), and every TextEditor mixed an EditorView from one copy with extension decorations from the other — crashing intermittently on mount.
Contributor
Confidence Score: 5/5This PR appears safe to merge. The narrower root correctly intercepts linked sources outside Reviews (1): Last reviewed commit: "fix: scope shared-dep resolver to the fr..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the resolver root at apps/studio, the local frappe-ui checkout counted as 'inside Studio', so its
@tiptapimports resolved from frappe-ui/node_modules while studio's own resolved from frontend/node_modules. The dep optimizer then bundled two prosemirror graphs (view 1.41.8 + 1.42.2), and every TextEditor mixed an EditorView from one copy with extension decorations from the other — crashing intermittently on mount.