feat: support 'Allow Guest' access for pages - #246
Conversation
Confidence Score: 4/5The PR is not yet safe to merge because existing clients can still call the removed component endpoint and receive a method-not-found failure. The bulk-fetch change resolves the per-component query issue, but no compatibility alias restores the previously whitelisted Files Needing Attention: studio/studio/doctype/studio_component/studio_component.py Reviews (6): Last reviewed commit: "fix: guest access description" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| check — like page definitions (see get_page), a component is markup with no draft | ||
| state; the data it renders stays permission-checked by the endpoints serving it.""" | ||
| component = frappe.get_cached_doc("Studio Component", component_name) | ||
| def get_component_data(component) -> dict: |
There was a problem hiding this comment.
When existing clients call the previously whitelisted get_component endpoint, the method no longer exists, causing those requests to fail; preserve a compatibility alias while migrating callers.
Context Used: Guidelines for reviewing Frappe Framework applicat... (source)
4ffd345 to
dd47f2a
Compare
1 participant
No description provided.