Skip to content

feat: add cloudflare support for DNS management - #7191

Open
samkit5495 wants to merge 12 commits into
frappe:developfrom
samkit5495:cloudflare-dns-support
Open

feat: add cloudflare support for DNS management#7191
samkit5495 wants to merge 12 commits into
frappe:developfrom
samkit5495:cloudflare-dns-support

Conversation

@samkit5495

Copy link
Copy Markdown

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The PR is not yet safe to merge because non-wildcard certificate issuance still fails before Certbot runs.

_certbot_command() unconditionally slices two characters from a plain non-wildcard domain before loading its Root Domain, so the prior certificate lookup failure remains outstanding despite the restored execution call.

Files Needing Attention: press/press/doctype/tls_certificate/tls_certificate.py

Fix All in Greploop

Reviews (4): Last reviewed commit: "Merge branch 'develop' into cloudflare-d..." | Re-trigger Greptile

Comment thread press/press/doctype/root_domain/root_domain.json Outdated
Comment thread press/press/doctype/tls_certificate/tls_certificate.py
@samkit5495 samkit5495 changed the title fix(root_domain): correct spelling of Cloudflare and update related API key references feat: add cloudflare support for DNS management Aug 12, 2026
Comment thread press/press/doctype/tls_certificate/tls_certificate.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants