feat: Add 'Create New App' flow to Pilot admin UI by ajmal1212 · Pull Request #223 · frappe/pilot

ajmal1212 · 2026-07-19T09:14:47Z

Summary

This PR implements the "Create New App" capability inside the Pilot admin UI. It allows users to scaffold a new Frappe app (equivalent to running bench new-app), automatically register/install it, optionally provision a clean repository on GitHub (via connected Git integrations), and deploy it directly onto selected sites.

Key Changes

Scaffolding Background Task (pilot/tasks/jobs/create_app_task.py):
- Executes Frappe's _create_app_boilerplate() non-interactively using Python snippet invocation.
- Installs the app into the virtual environment (pip install -e), registers it in apps.txt, and builds assets.
- Leverages personal access tokens from connected integrations to optionally provision a new GitHub repository, set up git remote origin, and commit/push initial branches. Includes branch checks to prevent overwriting repositories with existing history.
API Endpoint (admin/backend/api/v1/apps.py):
- Added a POST /apps/create endpoint that validates the proposed snake_case app name and schedules the background task.
GitHub API Client (pilot/integrations/git/github.py):
- Added create_repo() to support programmatic repository creation on GitHub.
UI Components:
- Added CreateAppDialog.vue containing form fields for metadata (Title, Publisher, Email, License) and GitHub settings.
- Added buttons to open the Dialog from both the Marketplace Filters and Site Detail header.

greptile-apps · 2026-07-19T09:17:38Z

Confidence Score: 5/5

Safe to merge; all previously-reported credential and rollback issues are resolved, and the remaining findings are style/design-system nits.

The core scaffolding, GitHub integration, and site-install paths are all guarded correctly. No present behavioral defects were found in this revision.

pilot/tasks/create_app.py (create_github complexity) and admin/frontend/src/components/apps/CreateAppDialog.vue (raw form elements)

_{Reviews (12): Last reviewed commit: "test(admin): update route inventory base..." | Re-trigger Greptile}

… git config, explicit sites list validation)

…ocess handling)

tanmoysrt · 2026-07-19T16:18:47Z

@ajmal1212 Please keep the PR description minimal and add screenshots for UI changes.
There was a major refactor in backend side. So, please update your feature branch.

ajmal1212 · 2026-07-20T02:38:56Z

this is the UI changes

tanmoysrt · 2026-07-21T05:11:46Z

Hi @ajmal1212
Can you move the new app button to marketplace instead ?

ajmal1212 · 2026-07-21T05:28:05Z

Hi @tanmoysrt,

I'll work on it.

…rotection

ajmal1212 · 2026-07-21T14:38:55Z

Fixed the rollback guard in CreateAppTask.run(). self.scaffold() and self.install_env() are now wrapped inside the try block so any failure during scaffolding or venv installation triggers full cleanup (directory removal, deregistration, pip uninstall). Added unit test test_run_triggers_rollback_on_install_env_failure in commit e9404d34.

…ow cleanup rollback

…llback handler

…unner.py

ajmal1212 · 2026-07-21T15:10:51Z

tanmoysrt · 2026-07-22T05:56:30Z

@siduck can you check the design

tanmoysrt · 2026-07-22T05:58:06Z

+@dataclass(kw_only=True)
+class CreateAppTask(Task):
+    command: ClassVar[str] = "create-app"
+
+    name: str
+    title: str = ""
+    description: str = ""
+    publisher: str = ""
+    email: str = ""
+    app_license: str = "mit"
+    create_github_repo: bool = False
+    github_repo_private: bool = False
+    sites: list[str] = field(default_factory=list)
+
+    def run(self) -> None:
+        # Essential App Scaffolding & Virtualenv Installation
+        try:
+            self.scaffold()
+            self.install_env()
+        except Exception as e:
+            self.report(f"App creation failed: {e}. Rolling back...")
+            try:


use bench new-app command instead ?
in current bench, that's named as bench make-app ig, you can rename it to new-app for compaitability with old bench

Aradhya-Tripathi · 2026-07-22T08:02:50Z

Using the bench new-app command will ensure the build files are correctly added.

tanmoysrt · 2026-07-24T05:18:38Z

Hi @ajmal1212
bench new-app and scaffold through framework has been added. Can you please use that ?

ajmal1212 · 2026-07-24T13:12:15Z

Sorry, guys. I haven't had enough time to work on it. Let's complete it today

ajmal1212 · 2026-07-24T13:32:38Z

Hi @tanmoysrt,

Updated this PR with the latest changes:

Merged upstream main containing bench new-app / NewAppOptions scaffolding.
Refactored CreateAppTask in pilot/tasks/create_app.py to use bench.new_app directly.
Updated unit tests & route baseline checks (test_create_app_task.py and test_admin_routes.py).

tanmoysrt · 2026-07-24T18:56:09Z

@ajmal1212

Please merge the base branch. There are already scaffolding code and command for creating new-app.
We shouldn't do it manually, framework itself handle that, we are just using frappe's internal make-app command.

https://github.com/frappe/pilot/blob/main/pilot/commands/apps/new.py

feat: implement create-app functionality

e82962e

greptile-apps Bot reviewed Jul 19, 2026

View reviewed changes

Comment thread pilot/integrations/git/github.py Outdated

fix: resolve PR review defects (content-type header, secure PAT push)

f5fa86d

greptile-apps Bot reviewed Jul 19, 2026

View reviewed changes

Comment thread pilot/tasks/jobs/create_app_task.py Outdated

Comment thread admin/backend/api/v1/apps.py Outdated

ajmal1212 added 3 commits July 19, 2026 09:28

fix: resolve second round of PR comments (secure environment variable…

c6aa7e1

… git config, explicit sites list validation)

fix: resolve critical PR review defects (TaskRunner unimported, subpr…

27f6dfa

…ocess handling)

fix: implement rollback on app creation failure (greptile review)

189d366

fix: refactor create-app task and resolve backend compatibility issues

da388b4

greptile-apps Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread pilot/tasks/create_app.py

ajmal1212 added 2 commits July 21, 2026 14:32

test: add unit tests for create app task and API endpoint

a32a986

fix(tasks): wrap scaffold and install_env in try block for rollback p…

e9404d3

…rotection

fix(tasks): raise RuntimeError instead of sys.exit in scaffold to all…

862cb1c

…ow cleanup rollback

greptile-apps Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread pilot/tasks/create_app.py Outdated

ajmal1212 added 2 commits July 21, 2026 14:57

fix(tasks): separate asset build and github creation from scaffold ro…

406d893

…llback handler

fix(tasks): prevent PAT leakage in .git/config and delete dead task_r…

4a5ff05

…unner.py

tanmoysrt requested a review from siduck July 22, 2026 05:56

tanmoysrt reviewed Jul 22, 2026

View reviewed changes

ajmal1212 added 2 commits July 24, 2026 13:25

Merge origin/main into feat/create-app

4edddd7

refactor(tasks): use bench.new_app and NewAppOptions in CreateAppTask

97b8fcd

test(admin): update route inventory baseline for 122 endpoints

4f4654a

Uh oh!

Conversation

ajmal1212 commented Jul 19, 2026

Summary

Key Changes

Uh oh!

greptile-apps Bot commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tanmoysrt commented Jul 19, 2026

Uh oh!

ajmal1212 commented Jul 20, 2026

Uh oh!

Uh oh!

tanmoysrt commented Jul 21, 2026

Uh oh!

ajmal1212 commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajmal1212 commented Jul 21, 2026

Uh oh!

Uh oh!

ajmal1212 commented Jul 21, 2026

Uh oh!

tanmoysrt commented Jul 22, 2026

Uh oh!

tanmoysrt Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

Aradhya-Tripathi commented Jul 22, 2026

Uh oh!

tanmoysrt commented Jul 24, 2026

Uh oh!

ajmal1212 commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajmal1212 commented Jul 24, 2026

Uh oh!

tanmoysrt commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

greptile-apps Bot commented Jul 19, 2026 •

edited

Loading

ajmal1212 commented Jul 21, 2026 •

edited

Loading

ajmal1212 commented Jul 24, 2026 •

edited

Loading