Skip to content

fix(programs): remove selected child rows - #2672

Open
MinHyeong-Lee wants to merge 1 commit into
frappe:developfrom
FNSERP:fix/program-selection-delete
Open

MinHyeong-Lee wants to merge 1 commit into
frappe:developfrom
FNSERP:fix/program-selection-delete

Conversation

@MinHyeong-Lee

Copy link
Copy Markdown

What changed

  • Remove selected Program Course and Program Member rows by checking every supported row identity.
  • Add focused tests for selections keyed by course, member, or child-row name.

Why

The Program lists use course and member as their row keys, while persisted child rows also have a name. The previous filter used expressions such as row.name || row.course. Once name existed, the selected course or member value was never compared, so clicking Delete left persisted rows in the Program.

The new helper checks both possible identities independently, matching the selection keys emitted by the list components while retaining support for child-row-name selections.

User impact

Program managers can delete selected courses and members from an existing Program and save the result.

Validation

  • yarn test src/tests/programSelection.test.ts src/tests/programForm.test.ts — 15 tests passed
  • yarn build — passed

@MinHyeong-Lee
MinHyeong-Lee marked this pull request as ready for review August 18, 2026 15:01
@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The helper correctly handles persisted and unsaved Program rows, and no reachable regression or rule violation was identified.

Reviews (1): Last reviewed commit: "fix(programs): remove selected child row..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants