Skip to content

fix: Import error - #5121

Closed
deepeshgarg007 wants to merge 1 commit into
frappe:version-16-hotfixfrom
deepeshgarg007:import_fix
Closed

deepeshgarg007 wants to merge 1 commit into
frappe:version-16-hotfixfrom
deepeshgarg007:import_fix

Conversation

@deepeshgarg007

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The PR appears safe to merge, but the unused scrub import should be removed or used.

The only change imports a valid Frappe helper that the report never references, leaving runtime behavior unchanged while adding dead code.

Files Needing Attention: hrms/hr/report/unpaid_expense_claim/unpaid_expense_claim.py

Fix all with Greploop Fix All in Claude Code Fix All in Codex

Reviews (1): Last reviewed commit: "fix: Import error" | Re-trigger Greptile


import frappe
from frappe import _
from frappe import _, scrub

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unused scrub import

scrub is never referenced in this report, so this change adds dead code without altering report behavior.

Suggested change
from frappe import _, scrub
from frappe import _

Context Used: Guidelines for reviewing Frappe Framework applicat... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants