fix: Import error - #5121
Closed
deepeshgarg007 wants to merge 1 commit into
Closed
fix: Import error#5121deepeshgarg007 wants to merge 1 commit into
deepeshgarg007 wants to merge 1 commit into
Conversation
deepeshgarg007
requested review from
asmitahase and
ruchamahabal
as code owners
August 18, 2026 07:33
Contributor
Confidence Score: 4/5The PR appears safe to merge, but the unused The only change imports a valid Frappe helper that the report never references, leaving runtime behavior unchanged while adding dead code. Files Needing Attention: hrms/hr/report/unpaid_expense_claim/unpaid_expense_claim.py Reviews (1): Last reviewed commit: "fix: Import error" | Re-trigger Greptile |
|
|
||
| import frappe | ||
| from frappe import _ | ||
| from frappe import _, scrub |
Contributor
There was a problem hiding this comment.
scrub is never referenced in this report, so this change adds dead code without altering report behavior.
Suggested change
| from frappe import _, scrub | |
| from frappe import _ |
Context Used: Guidelines for reviewing Frappe Framework applicat... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.