Skip to content

feat(shift_type): add configurable option to mark absent on same day - #5083

Merged
deepeshgarg007 merged 6 commits into
frappe:developfrom
iamkhanraheel:feat/configurable_absent_marking
Sep 10, 2026
Merged

deepeshgarg007 merged 6 commits into
frappe:developfrom
iamkhanraheel:feat/configurable_absent_marking

Conversation

@iamkhanraheel

@iamkhanraheel iamkhanraheel commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Reason

  • There was no way to mark Absent on the same day, the system always waited until the next day, regardless of when the shift's checkout window closed.
  • This hardcoded 1-day wait had no way to opt out, delaying attendance review/correction until the following day

Changes Done

  • Added an Absent Buffer (Days) field on Shift Type (default 1 — existing behavior unchanged unless changed). Set to 0 to mark Absent the same day, or any higher number for a longer buffer.
  • Setting it to 0 requires Automatically update Last Sync of Checkin too; validated on save, since same-day marking depends on it.
  • get_start_and_end_dates() now uses this configurable buffer instead of a hardcoded 1-day wait.
image

Closes: #5082

@iamkhanraheel
iamkhanraheel marked this pull request as ready for review August 11, 2026 13:21
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge within the scope of this follow-up review.

Reviews (6) · Last reviewed commit: "Merge remote-tracking branch 'upstream/d..."

Comment thread hrms/hr/doctype/shift_type/test_shift_type.py
@mergify

mergify Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@asmitahase

Copy link
Copy Markdown
Member

add screenshots/videos

@github-actions

Copy link
Copy Markdown

This pull request is being marked as inactive because of no recent activity.
If your PR hasn't been reviewed, it's likely because it doesn't fullfill the contribution guidelines. Please read them carefully and fix the pull request. When you are sure all items are checked, please ping relevant codeowner in the comment. Be nice, they have a lot on their plate too.

It will be closed in 3 days if no further activity occurs.
Thank you for contributing!

@deepeshgarg007
deepeshgarg007 merged commit e1fcc36 into frappe:develop Sep 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configurable Auto Attendance Absent Processing

3 participants