Skip to content

fix: apply depends_on visibility to customer portal ticket fields - #3615

Open
ews-pgasser wants to merge 3 commits into
frappe:developfrom
ews-pgasser:fix/3614-template-field-depends-on
Open

ews-pgasser wants to merge 3 commits into
frappe:developfrom
ews-pgasser:fix/3614-template-field-depends-on

Conversation

@ews-pgasser

Copy link
Copy Markdown
Contributor

fixes #3614

@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

  • Safe to merge — the change is a minimal, well-scoped addition that reuses proven logic with no new failure modes.
  • The two new filter calls delegate entirely to an already-exercised helper. The doctype JSON addition is additive and the type change is backward-compatible.
  • No files require special attention.

Fix All in Greploop

Reviews (3): Last reviewed commit: "Merge branch 'develop' into fix/3614-tem..." | Re-trigger Greptile

@codecov-commenter

codecov-commenter commented Jul 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.76%. Comparing base (c037dcf) to head (4a38e8a).
⚠️ Report is 243 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3615      +/-   ##
===========================================
+ Coverage    71.63%   73.76%   +2.13%     
===========================================
  Files          145      148       +3     
  Lines        10106    10841     +735     
===========================================
+ Hits          7239     7997     +758     
+ Misses        2867     2844      -23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ews-pgasser

Copy link
Copy Markdown
Contributor Author

@RitvikSardana please merge asap 👍

@ews-pgasser

Copy link
Copy Markdown
Contributor Author

Bump @RitvikSardana

@ews-pgasser

Copy link
Copy Markdown
Contributor Author

Could you please check this PR? @aerodeval

@ews-pgasser

Copy link
Copy Markdown
Contributor Author

@aerodeval @RitvikSardana

@aerodeval

Copy link
Copy Markdown
Member

@ews-pgasser we will have a look and let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customer portal shows empty/irrelevant custom fields; no conditional field visibility in HD Ticket Template

3 participants