fix: correct Created On date range filter behavior - #3602
Open
harrishragavan wants to merge 1 commit into
Open
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Confidence Score: 5/5Targeted two-file fix for a well-understood parsing mismatch; no side-effects on other filter operators. Both changed functions now correctly branch on Array.isArray, the ' to ' delimiter detection covers the actual DateRangePicker output format, and legacy comma-separated paths are preserved. No regressions visible in adjacent logic. No files require special attention. Reviews (1): Last reviewed commit: "fix: correct Created On date range filte..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: "Created On"
BetweenDate Filter Returns No Results (#3518)Problem
The Created On filter does not work correctly when the Between operator is selected. Even when records exist within the selected date range, the ticket list incorrectly displays "No data available."
This issue occurs because the front-end does not consistently handle the value emitted by
DateRangePickerwhen constructing the filter value.Root Cause
DateRangePickeremits the selected date range as astring[]([startDate, endDate]), while parts of the filtering logic expected a comma-separated string.As a result:
Solution
The date range handling has been updated to support both array and string inputs, ensuring the Between filter is parsed correctly regardless of the value format returned by
DateRangePicker.The implementation now:
string[]value emitted byDateRangePicker.This restores the expected behavior for the Created On → Between filter while preserving compatibility with existing filter functionality.
