Repository navigation
ci: Publish prebuilt assets for Pilot - #604
Merged
Merged
Conversation
Build the app's assets in CI for each push and publish them on the release assets-<branch>, so Pilot benches download them instead of building on the server.
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| jobs: | ||
| assets: | ||
| name: Pre-build assets | ||
| uses: frappe/pilot/.github/workflows/app-assets.yml@develop |
Contributor
There was a problem hiding this comment.
develop branch, so it can change without a Gameplan change. On the next Gameplan push, that code receives contents: write and could replace published assets or other repository contents. Pin it to a reviewed commit SHA. How this was verified: The called workflow uses a mutable external ref and receives the caller job’s write permission.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/assets.yml
Line: 10
Comment:
**Mutable workflow has write access** The Pilot workflow is loaded from its `develop` branch, so it can change without a Gameplan change. On the next Gameplan push, that code receives `contents: write` and could replace published assets or other repository contents. Pin it to a reviewed commit SHA. **How this was verified:** The called workflow uses a mutable external ref and receives the caller job’s write permission.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Test reportBackend ✅ 1280 passed · 7m 49s 50 modules
Coverage 90.3% (3,632 / 4,020 statements) Backend coverage by area
Least covered
Measured over product code only. Excluded: test suite ( Cypress ✅ 157 passed · 9m 38s 45 specs
Coverage 73.1% (6,343 / 8,677 statements) Frontend coverage by area
Least covered
Collected by Cypress against an istanbul-instrumented build, so it marks lines that ran, not lines a spec asserted on — read it to find untouched areas, not as a quality score against the backend number. Excluded: generated doctype types ( Updated for commit 73633ca. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build the Gameplan assets in CI and publish them on the release
assets-<branch>. Pilot benches download them and skip the asset build, the slowest and most memory-hungry step of an install or update.What changed
Pre-build assetsworkflow for pushes todevelop.See Prebuilt Assets.