Skip to content

fix(polls): give composer errors and checkbox options room to breathe - #552

Open
adityapradhan10 wants to merge 1 commit into
frappe:developfrom
adityapradhan10:fix/poll-composer-spacing
Open

fix(polls): give composer errors and checkbox options room to breathe#552
adityapradhan10 wants to merge 1 commit into
frappe:developfrom
adityapradhan10:fix/poll-composer-spacing

Conversation

@adityapradhan10

Copy link
Copy Markdown

Summary

  • Add mt-2 on the discussion composer ErrorMessage, so a poll (or comment) validation error is no longer flush against Discard / Submit.
  • Group the Anonymous and Multiple answers checkboxes with flex gap-2 so they aren't cramped.

Fixes #551

Test plan

  • Open a discussion, switch the composer to Poll, submit with duplicate option text, and confirm a gap between the buttons and ValidationError: Duplicate options not allowed.
  • Confirm Anonymous and Multiple answers sit side by side with a small gap, and that checking one still disables the other.
  • Trigger a comment insert error and confirm it also has spacing below the action row.

Evidence

Fixed - Gameplan Poll error spacing UI bug

@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The changes are presentation-only and preserve existing bindings, disabled states, and update handlers without an actionable regression.

Reviews (1): Last reviewed commit: "fix(polls): give composer errors and che..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poll composer: validation error sits too close to Discard/Submit

1 participant