Skip to content

fix: map PY state to Puducherry to match ERPNext state list#443

Merged
venkat102 merged 1 commit into
frappe:developfrom
aerele:fix/indian-state-mapping
Jul 8, 2026
Merged

fix: map PY state to Puducherry to match ERPNext state list#443
venkat102 merged 1 commit into
frappe:developfrom
aerele:fix/indian-state-mapping

Conversation

@Bhavathariniya

@Bhavathariniya Bhavathariniya commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

Corrects the Unicommerce → ERPNext state mapping for Puducherry so orders shipping there pass address/state validation.

Issue

  • The PY entry in UNICOMMERCE_INDIAN_STATES_MAPPING returned "Pondicherry", but ERPNext's India state list uses the official name "Puducherry".
  • As a result, orders with a Puducherry shipping/billing address failed state validation and did not sync cleanly.

Fix

  • Updated the PY mapping from "Pondicherry" to "Puducherry" in constants.py to match ERPNext's state list exactly.

Impact

  • One-line data mapping change; no logic or schema changes.
  • Puducherry orders now map to a valid ERPNext state and sync without validation errors.

Backport needed in v15

@Bhavathariniya
Bhavathariniya requested a review from ankush as a code owner July 2, 2026 05:49
@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

Single data mapping correction in a static dictionary; no logic, schema, or API changes.

The change is a one-line string update in a lookup table, directly aligning with ERPNext's official state name. No side effects or regressions are expected.

No files require special attention.

Reviews (3): Last reviewed commit: "fix: map PY state to Puducherry to match..." | Re-trigger Greptile

@Bhavathariniya
Bhavathariniya force-pushed the fix/indian-state-mapping branch from 6fecaec to 78ef5db Compare July 7, 2026 12:24
@mergify

mergify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@sudarsan2001

Copy link
Copy Markdown
Contributor

Reviewed

@venkat102
venkat102 force-pushed the fix/indian-state-mapping branch from 78ef5db to 6dd0f76 Compare July 8, 2026 06:33
@venkat102
venkat102 merged commit 2e2be46 into frappe:develop Jul 8, 2026
6 checks passed
@venkat102

Copy link
Copy Markdown
Member

@mergify backport to version-15

@mergify

mergify Bot commented Jul 8, 2026

Copy link
Copy Markdown

backport to version-15

❌ No backport have been created

Details
  • Backport to branch to failed

GitHub error: Branch not found

venkat102 added a commit that referenced this pull request Jul 8, 2026
fix: map PY state to Puducherry to match ERPNext state list (backport #443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants