fix: polygon tool icon reads as freeform, not a fixed pentagon - #561
Open
bvnaik05 wants to merge 1 commit into
Open
fix: polygon tool icon reads as freeform, not a fixed pentagon#561bvnaik05 wants to merge 1 commit into
bvnaik05 wants to merge 1 commit into
Conversation
The Polygon tile (click-to-place-a-vertex drawing, no fixed side count) used lucide-pentagon — a symmetric, regular five-sided glyph that promises a specific shape the tool doesn't draw. An earlier pass (frappe#451) deliberately chose it over the prior pen-tool icon, reasoning "the tile draws a polygon, so it should look like one" — true, but a regular pentagon is a much more specific claim than "polygon". Draw an irregular polygon outline instead, the same way the custom polygon tile beside it draws its own glyph rather than reaching for a Lucide icon. An asymmetric shape says "you decide the shape" instead of "insert a pentagon".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Polygon tile in the Shapes menu (click-to-place-a-vertex drawing — no fixed side count) used
lucide-pentagon: a symmetric, regular five-sided glyph. That icon promises a specific shape ("insert a pentagon") the tool doesn't actually draw, which reads as misleading for a tool whose whole point is that you decide the shape by clicking out its vertices yourself.An earlier pass (#451) deliberately picked this over a prior pen-tool icon, reasoning "the tile draws a polygon, so it should look like one" — true, but a regular pentagon is a much more specific claim than "a polygon".
Fix
Draw an irregular polygon outline instead, the same way the custom-polygon tile beside it (the one that asks for a side count) already draws its own glyph rather than reaching for a Lucide icon. An asymmetric outline says "you decide the shape" instead of "insert a pentagon" — and stays visually distinct from that neighboring tile's regular,
n-labeled glyph.frontend/src/components/floating/ShapeGlyph.vue: newpolygon-freeformglyph family, an irregular polygon outline.frontend/src/composables/useInsertCatalog.js: the Polygon tile now usesglyph: 'polygon-freeform'instead oficon: 'lucide-pentagon'.Testing
yarn vitest run— 149 files / 1731 tests pass.🤖 Generated with Claude Code