-
Notifications
You must be signed in to change notification settings - Fork 0
Optimize filetree request path #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… filetree from backend has changed
… the entire tree, which was expensive
|
| } | ||
|
|
||
| loadFileTree() | ||
| void loadFileTree() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does void here do?
| if (a.type !== b.type) { | ||
| return a.type === 'DIRECTORY' ? -1 : 1 | ||
| } | ||
| return a.name.localeCompare(b.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sorted function is the same as the one used for the root, maybe you could reuse that instead recreating it here and possibly having to edit both?



Closes #173