-
Notifications
You must be signed in to change notification settings - Fork 0
Open files in editor #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open files in editor #115
Conversation
…s any mandatory attributes when the suggestion is inserted. Also suggests attribute names when typing within a tag
…me for fetching configurations.
# Conflicts: # src/main/frontend/app/routes/builder/canvas/flow.tsx
…savebutton to sidebar
philipsens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me a long time to understand some of the logic. I think this code can improve a lot in readability. It might be nice to do a little refactor together so you can see where I'm coming from.
|
@philipsens I've opened a new pull request, #117, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
Applied the feedback, and I agree that I should chill with the nesting a bit 😄 Quick and easy to write, but difficult to decipher at times, even for my own code looking back at it a week later. |
…s not necessarily true, also removed the default tab
Closes #110