Skip to content

fix(#469): adjusted sign-up and sign-in prompt alignment #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emmadal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(#469): adjusted sign-up and sign-in prompt alignment #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/registry/src/blocks/sign-in-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,18 @@ export function SignInForm() {
<Text>Continue</Text>
</Button>
</View>
<Text className="text-center text-sm">
Don&apos;t have an account?{' '}
<View className="flex-row items-center">
<Text className="text-center text-sm">
Don&apos;t have an account?{" "}
</Text>
<Pressable
onPress={() => {
// TODO: Navigate to sign up screen
}}>
<Text className="text-sm underline underline-offset-4">Sign up</Text>
}}
>
<Text className="text-sm underline">Sign up</Text>
Comment on lines -83 to +86

@mrzachnugent mrzachnugent Jan 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like underline-offset-4 was removed. Maybe it's because it doesn't do anything on mobile but its for the web platform. Could you please add it back? You can add the prefix web: to make it clearer.

</Pressable>
</Text>
</View>
<View className="flex-row items-center">
<Separator className="flex-1" />
<Text className="text-muted-foreground px-4 text-sm">or</Text>
Expand Down
9 changes: 6 additions & 3 deletions packages/registry/src/blocks/sign-up-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,18 @@ export function SignUpForm() {
<Text>Continue</Text>
</Button>
</View>
<Text className="text-center text-sm">
Already have an account?{' '}
<View className="flex-row items-center">
<Text className="text-center text-sm">
Already have an account?{" "}
</Text>
<Pressable
onPress={() => {
// TODO: Navigate to sign in screen
}}>
<Text className="text-sm underline underline-offset-4">Sign in</Text>

@mrzachnugent mrzachnugent Jan 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add the web: prefix for underline-offset-4 in the sign-in-form, could you also add it here please?

@emmadal emmadal Jan 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I will do it

</Pressable>
</Text>
</View>

<View className="flex-row items-center">
<Separator className="flex-1" />
<Text className="text-muted-foreground px-4 text-sm">or</Text>
Expand Down