Skip to content

fix(tox): Add fixed chardet ver. at requirements-dev.txt#189

Merged
bjk7119 merged 1 commit intomainfrom
fixtox_new
Mar 11, 2026
Merged

fix(tox): Add fixed chardet ver. at requirements-dev.txt#189
bjk7119 merged 1 commit intomainfrom
fixtox_new

Conversation

@bjk7119
Copy link
Contributor

@bjk7119 bjk7119 commented Mar 11, 2026

Description

  • Fix chardet version under 5.0.0 because of using requirements-dev.txt when running tox -e release command,

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Summary by CodeRabbit

  • Chores
    • Updated development dependencies to improve build stability.

Signed-off-by: Jaekwon Bang <jaekwon.bang@lge.com>
@bjk7119 bjk7119 requested a review from dd-jy March 11, 2026 08:51
@bjk7119 bjk7119 self-assigned this Mar 11, 2026
@bjk7119 bjk7119 added the chore [PR/Issue] Refactoring, maintenance the code label Mar 11, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 415639c4-77e8-47b2-8555-9b218d544e66

📥 Commits

Reviewing files that changed from the base of the PR and between 2d36db1 and 491fe73.

📒 Files selected for processing (1)
  • requirements-dev.txt

📝 Walkthrough

Walkthrough

Added chardet<5.0.0 dependency constraint to requirements-dev.txt, resolved existing duplication, and ensured proper file termination with newline character.

Changes

Cohort / File(s) Summary
Dependency Constraint
requirements-dev.txt
Added chardet<5.0.0 version constraint; removed duplicate flake8 entry; added trailing newline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Fix tox error #181: Adds the same chardet<5.0.0 dependency constraint to requirements.txt in a parallel repository.

Suggested reviewers

  • dd-jy
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a fixed chardet version constraint to requirements-dev.txt for tox purposes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fixtox_new

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bjk7119 bjk7119 merged commit 6938614 into main Mar 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant