Skip to content

Fix tox error#180

Closed
bjk7119 wants to merge 1 commit intomainfrom
fixtox
Closed

Fix tox error#180
bjk7119 wants to merge 1 commit intomainfrom
fixtox

Conversation

@bjk7119
Copy link
Contributor

@bjk7119 bjk7119 commented Mar 9, 2026

Description

Fix tox error at github action

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Summary by CodeRabbit

  • Chores
    • Optimized PyInstaller configuration for the build process.
    • Enhanced dependency handling by including additional package resources in the build.
    • Improved test discovery by excluding unnecessary directories from test execution.

@bjk7119 bjk7119 requested a review from dd-jy March 9, 2026 04:59
@bjk7119 bjk7119 self-assigned this Mar 9, 2026
@bjk7119 bjk7119 added the chore [PR/Issue] Refactoring, maintenance the code label Mar 9, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

📝 Walkthrough

Walkthrough

This PR modifies PyInstaller and test configurations. It simplifies cli.spec by removing path entries and reducing hidden imports, extends hook-fosslight_binary.py to include resources from additional packages (binaryornot, chardet), and adds pytest configuration to exclude specific directories from test discovery.

Changes

Cohort / File(s) Summary
PyInstaller Configuration
cli.spec, hooks/hook-fosslight_binary.py
Simplifies cli.spec by removing pathex entries and reducing hiddenimports; extends hook-fosslight_binary.py to collect data files, binaries, and hidden imports from binaryornot and chardet packages.
Test Configuration
tox.ini
Adds pytest norecursedirs setting to exclude third_party, build, dist, .tox, .git, and \_\_pycache\_\_ directories from test discovery.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix tox error' is too vague and does not clearly describe the specific changes made (pytest configuration updates, PyInstaller hook modifications, and cli.spec adjustments). Consider using a more descriptive title that indicates the main change, such as 'Update PyInstaller configuration and pytest settings' or 'Configure PyInstaller hooks for additional packages'.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fixtox

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bjk7119 bjk7119 closed this Mar 9, 2026
@bjk7119 bjk7119 reopened this Mar 9, 2026
@bjk7119 bjk7119 closed this Mar 9, 2026
@bjk7119 bjk7119 deleted the fixtox branch March 11, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant