Shortcuts streamline & help page the second - #1612
Conversation
✅ Deploy Preview for selfoss canceled.
|
jtojnar
left a comment
jtojnar
left a comment
There was a problem hiding this comment.
Thanks. This looks very good already, just few details.
|
@jtojnar Thanks for the review! Do I amend the changes into the original commits, or apply them as individual commits? |
|
Please amend/use fixup commits and then |
…ate-heavy format All keybindings have been tested manually since conversion
…from the docs - Adapted arrow left & arrow right to the symbol used in docs - Exception: "item" is replaced by "entry" for consistency - Exception: Renamed throws to throw to previous / throw to next Link to docs as of development of this commit: https://github.com/fossar/selfoss/blob/81187a39a1b1db0e2d48fb0fccad949ca771a635/docs/content/docs/usage/shortcuts.md
1731898 to
c604290
Compare
| readableKeycombo = <kbd>{keybinding.readableName}</kbd>; | ||
| } else if (keycombo.includes('+')) { | ||
| const keys = keycombo | ||
| .split('+') // key={key} required for TS |
There was a problem hiding this comment.
// key={key} required for TS
This is general react thing: https://react.dev/learn/rendering-lists
It should not really be necessary here as the keybindings will never change but the compiler unfortunately is not smart enough.
I am surprised it does not complain about the fragment containing dt + dd.
| description: 'show help', | ||
| action: () => {}, | ||
| }, | ||
| '[Shift]+?': { |
There was a problem hiding this comment.
We should also add it to the static docs.
There was a problem hiding this comment.
Sure! Although, perhaps finishing up the auto-generated docs table might be better to make sure nothing falls through the cracks properly? Shift+R is also undocumented in the docs as of now
dd420ff to
d918445
Compare
|
With the exception of your fragment comment, everything has been implemented! Some notes:
|
d918445 to
b04039f
Compare
Thanks to Jan for getting it to display using <dialog>! And dealing with a bunch of my questions. Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
b04039f to
e342a0f
Compare
2 participants
Re-open because Github doesnt like force pushes. Alas. Cleaned up & finished version of #1609 !