Repository navigation
ci: SDK QA & release automation - #65
Merged
Merged
Conversation
Trigger on release: published, take the version from the tag, publish prereleases to the next dist-tag, skip versions already on npm, and add a verify job that polls the dist-tag. Main keeps 0.0.0-dev as the version.
Replace build, lint, test and sonarqube workflows with one ci.yml (lint, format, typecheck, build, unit-tests, api-check, package-check, sonarqube, dependency-review, workflow-lint) and a PR Check Summary job whose allowed skips live in scripts/pr-check-summary.mjs. Add PR title, weekly CodeQL and Scorecard workflows. Every job has harden-runner, SHA-pinned actions and a timeout. Fix the violations the new checks found: the published types failed node16 resolution (extensionless internal imports, and ESM-typed declarations for the module.exports CommonJS bundle). Types are now rolled up by API Extractor, with an export = declaration for CJS, and the public API is snapshotted in packages/js/etc/js.api.md.
The registry lookup only replaced the first slash in the package name, which CodeQL flags as incomplete sanitization (js/incomplete-sanitization). Encode the full name with encodeURIComponent and keep the leading @.
e2e/server boots ghcr.io/formbricks/formbricks with Postgres, Valkey and SpiceDB, bootstraps the tenant in SQL, drains the authz outbox, seeds through the V1 API, asserts the response and cleans up. It needs only bash, curl, jq and docker compose, so the other SDK repos can copy it. e2e/playwright drives the playground built from the workspace; the playground gets inputs for the userId, attribute and action.
Also point AGENTS.md at the E2E harness.
…on' into dhruwang/eng-7207-js-e2e-harness-pilot-golden-journey
Reuse the Enterprise license the main repo's E2E checks already use, under the same secret name, instead of a separate QA license secret.
… v-prefixed tags resolve-release.mjs now takes positional args and the current latest version, sends an older stable version to release-<major>.<minor> so it never moves latest, and accepts plain semver tags only. verify passes when the version is published and its dist-tag points at it or at a newer version on the same channel, so re-running an old release stays green. Every release job checks out the tag commit, and checkout and pnpm/action-setup now use the CI pins.
…flow Link the Notion runbook, name the E2E workflow by its file, and match the tag and dist-tag rules to the release workflow.
Run e2e/*/test/*.sh in unit-tests (fork PRs run them too) instead of e2e.yml, add shellcheck for e2e/**/*.sh and scripts/*.sh to workflow-lint, key the concurrency group on the commit SHA, and bump the SonarQube scan action to v8.5.0, the newest pin across the SDKs.
Dhruwang
marked this pull request as ready for review
November 16, 2026 10:26
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Part of the SDK QA & Release Automation project (Linear P-ENG-89). Consistent CI checks (
PR Check Summaryas the single required check), native E2E against the release Docker image, and a tag-driven release workflow.Decisions: https://linear.app/formbricks/document/4-engineering-decisions-2de7e803ebdc
Tickets
Changes SDK users will notice
exportsnow has separateimport/requireentries with anindex.d.cts, and the.d.tsis rolled up by API Extractor. This fixes the attw findings; consumers on unusual resolvers may notice.1.2.3); avprefix now fails the release.Before merging
ENTERPRISE_LICENSE_KEY(Enterprise license with Contacts).PR Check Summary(source: GitHub Actions).Runbook: https://app.notion.com/p/419e5de84a5881cd8091c30193db8607