Skip to content

ci: SDK QA & release automation - #65

Merged
mattinannt merged 22 commits into
mainfrom
dhruwang/sdk-qa-release-automation
Nov 17, 2026
Merged

mattinannt merged 22 commits into
mainfrom
dhruwang/sdk-qa-release-automation

Conversation

@Dhruwang

@Dhruwang Dhruwang commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

What

Part of the SDK QA & Release Automation project (Linear P-ENG-89). Consistent CI checks (PR Check Summary as the single required check), native E2E against the release Docker image, and a tag-driven release workflow.

Decisions: https://linear.app/formbricks/document/4-engineering-decisions-2de7e803ebdc

Tickets

  • Closes ENG-7206 — JS: CI parity
  • Closes ENG-7207 — JS: E2E harness pilot + golden journey
  • Closes ENG-7208 — JS: tag-driven release + verify

Changes SDK users will notice

  • Published typings are restructured: exports now has separate import/require entries with an index.d.cts, and the .d.ts is rolled up by API Extractor. This fixes the attw findings; consumers on unusual resolvers may notice.
  • Release tags must be bare semver (1.2.3); a v prefix now fails the release.

Before merging

  • All checks are green, including E2E: the full targeted journey runs against the org secret ENTERPRISE_LICENSE_KEY (Enterprise license with Contacts).
  • After merging, the ruleset's only required check becomes PR Check Summary (source: GitHub Actions).

Runbook: https://app.notion.com/p/419e5de84a5881cd8091c30193db8607

Trigger on release: published, take the version from the tag, publish
prereleases to the next dist-tag, skip versions already on npm, and add a
verify job that polls the dist-tag. Main keeps 0.0.0-dev as the version.
Comment thread scripts/release/npm-registry.mjs Fixed
Replace build, lint, test and sonarqube workflows with one ci.yml
(lint, format, typecheck, build, unit-tests, api-check, package-check,
sonarqube, dependency-review, workflow-lint) and a PR Check Summary job
whose allowed skips live in scripts/pr-check-summary.mjs. Add PR title,
weekly CodeQL and Scorecard workflows. Every job has harden-runner,
SHA-pinned actions and a timeout.

Fix the violations the new checks found: the published types failed
node16 resolution (extensionless internal imports, and ESM-typed
declarations for the module.exports CommonJS bundle). Types are now
rolled up by API Extractor, with an export = declaration for CJS, and
the public API is snapshotted in packages/js/etc/js.api.md.
The registry lookup only replaced the first slash in the package name,
which CodeQL flags as incomplete sanitization (js/incomplete-sanitization).
Encode the full name with encodeURIComponent and keep the leading @.
e2e/server boots ghcr.io/formbricks/formbricks with Postgres, Valkey and SpiceDB, bootstraps the tenant in SQL, drains the authz outbox, seeds through the V1 API, asserts the response and cleans up. It needs only bash, curl, jq and docker compose, so the other SDK repos can copy it. e2e/playwright drives the playground built from the workspace; the playground gets inputs for the userId, attribute and action.
Also point AGENTS.md at the E2E harness.
…on' into dhruwang/eng-7207-js-e2e-harness-pilot-golden-journey
Reuse the Enterprise license the main repo's E2E checks already use,
under the same secret name, instead of a separate QA license secret.
… v-prefixed tags

resolve-release.mjs now takes positional args and the current latest
version, sends an older stable version to release-<major>.<minor> so it
never moves latest, and accepts plain semver tags only. verify passes
when the version is published and its dist-tag points at it or at a
newer version on the same channel, so re-running an old release stays
green. Every release job checks out the tag commit, and checkout and
pnpm/action-setup now use the CI pins.
…flow

Link the Notion runbook, name the E2E workflow by its file, and match
the tag and dist-tag rules to the release workflow.
Run e2e/*/test/*.sh in unit-tests (fork PRs run them too) instead of
e2e.yml, add shellcheck for e2e/**/*.sh and scripts/*.sh to
workflow-lint, key the concurrency group on the commit SHA, and bump
the SonarQube scan action to v8.5.0, the newest pin across the SDKs.
@Dhruwang
Dhruwang marked this pull request as ready for review November 16, 2026 10:26
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3cef2124-ce05-40fb-a8ab-ec1856f2dd9c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@Dhruwang
Dhruwang requested a review from mattinannt November 17, 2026 07:53

@mattinannt mattinannt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 🚀

@mattinannt
mattinannt added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 24fd61b Nov 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants