Skip to content

Conversation

@flemzord
Copy link
Member

No description provided.

The previous demo.yaml mixed CE and EE concerns (auth, stargate,
delegatedOIDCServer) making it unsuitable for Community Edition
deployments. Split into dedicated profiles:
- demo-ce.yaml: single stack with CE-only modules (gateway, ledger)
- demo-ee.yaml: full EE demo with auth, stargate, cloudprem/dex config

Also add port-forward command to NOTES.txt for CE demo mode.
Document the available CE and EE profiles with quick start examples.
…config

- Consolidate demo-dev + demo-ci into single demo-demo stack (v3.1)
- Remove stargate module (was marked as ToFix)
- Add cert-manager annotations and TLS for all ingresses
  (gateway, console, portal, membership, dex)
- Add nginx proxy buffer annotations for control plane services
- Disable migration hooks with ttlSecondsAfterFinished
- Updated the demo profile to use 'demo-demo' instead of 'demo-dev'.
- Removed the 'demo-ci' stack and its associated modules for simplification.
@flemzord flemzord requested a review from a team as a code owner February 10, 2026 13:21
@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • charts/cloudprem/Chart.yaml is excluded by !**/*.yaml
  • charts/formance/Chart.yaml is excluded by !**/*.yaml
  • charts/membership/Chart.yaml is excluded by !**/*.yaml
  • charts/stargate/Chart.yaml is excluded by !**/*.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Several Helm chart README badges were updated from beta to stable versions across multiple charts; the Formance chart README version was bumped to 1.0.1. A Port-forward block was added to charts/formance/templates/NOTES.txt to conditionally emit kubectl port-forward commands for gateway stacks when not in EnterpriseEdition.

Changes

Cohort / File(s) Summary
Root README
README.md
Updated chart Version/AppVersion table entries from beta to stable values (several rows changed).
Formance chart
charts/formance/README.md, charts/formance/templates/NOTES.txt
Bumped chart version badge to 1.0.1; removed -0 suffixes in k8s/chart version constraints; changed Dex image tag from v2.0.0-beta.2v2.0.0; added Port-forward section in NOTES.txt that iterates .Values.regions.stacks and emits kubectl port-forward -n <stack> svc/gateway 8080:8080 when not EnterpriseEdition.
Cloudprem chart
charts/cloudprem/README.md
Replaced 4.0.0-beta.224.0.0; normalized k8s requirement >=1.14.0-0>=1.14.0; removed trailing suffixes in requirements table and updated Dex tag to v2.0.0; minor formatting fixes.
Console / Membership / Portal charts
charts/console-v3/README.md, charts/membership/README.md, charts/portal/README.md
Replaced beta Version/AppVersion badges with stable 3.0.0/v2.0.0; updated Kubernetes requirement >=1.14.0-0>=1.14.0; trimmed trailing spaces and fixed small formatting in membership entries.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant User
participant Helm as Helm (chart templates / NOTES)
participant Renderer as Helm Renderer
participant CLI as kubectl
participant Gateway as svc/gateway
User->>Helm: helm install / helm upgrade
Helm->>Renderer: render templates including NOTES.txt
Renderer-->>User: NOTES containing port-forward commands for each region.stack with gateway (if not EnterpriseEdition)
User->>CLI: run shown kubectl port-forward -n <stack> svc/gateway 8080:8080
CLI->>Gateway: establish port-forward tunnel
Gateway-->>User: gateway accessible via localhost:8080

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through badges, neat and spry,

Beta tags fell, now stable lie.
NOTES now hum a port-forward song,
Tunnel open — hop along! 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'feat: split demo profiles ce ee' does not clearly match the actual changes, which involve updating Helm chart versions from beta to stable and adding port-forward instructions. Revise the title to accurately reflect the main changes, such as 'feat: promote Helm charts from beta to stable versions' or 'feat: update charts to v3/v4 stable releases'.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose of promoting beta versions to stable and any related configuration changes across the Helm charts.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/split-demo-profiles-ce-ee

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@charts/formance/templates/NOTES.txt`:
- Around line 106-115: The port-forward block uses hasKey $config.modules
"gateway" which is case-sensitive and will miss capitalized module keys like
"Gateway"; update the check in the template (the hasKey usage around
$config.modules) to perform a case-insensitive match or normalize keys before
checking—for example iterate over the keys of $config.modules and compare
strings lowercased to "gateway" or add a helper/pipe to lower the key before
calling hasKey so the port-forward branch triggers when any case variant of the
gateway module is present.

@flemzord flemzord enabled auto-merge (squash) February 11, 2026 10:22
Copy link
Contributor

@Dav-14 Dav-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flemzord flemzord requested a review from Dav-14 February 11, 2026 11:21
@flemzord flemzord merged commit 033c84b into main Feb 12, 2026
4 of 5 checks passed
@flemzord flemzord deleted the feat/split-demo-profiles-ce-ee branch February 12, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants