-
Notifications
You must be signed in to change notification settings - Fork 5
feat: split demo profiles ce ee #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The previous demo.yaml mixed CE and EE concerns (auth, stargate, delegatedOIDCServer) making it unsuitable for Community Edition deployments. Split into dedicated profiles: - demo-ce.yaml: single stack with CE-only modules (gateway, ledger) - demo-ee.yaml: full EE demo with auth, stargate, cloudprem/dex config Also add port-forward command to NOTES.txt for CE demo mode.
Document the available CE and EE profiles with quick start examples.
…config - Consolidate demo-dev + demo-ci into single demo-demo stack (v3.1) - Remove stargate module (was marked as ToFix) - Add cert-manager annotations and TLS for all ingresses (gateway, console, portal, membership, dex) - Add nginx proxy buffer annotations for control plane services - Disable migration hooks with ttlSecondsAfterFinished
…ingress config" This reverts commit cd35572.
- Updated the demo profile to use 'demo-demo' instead of 'demo-dev'. - Removed the 'demo-ci' stack and its associated modules for simplification.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (4)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughSeveral Helm chart README badges were updated from beta to stable versions across multiple charts; the Formance chart README version was bumped to 1.0.1. A Port-forward block was added to Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@charts/formance/templates/NOTES.txt`:
- Around line 106-115: The port-forward block uses hasKey $config.modules
"gateway" which is case-sensitive and will miss capitalized module keys like
"Gateway"; update the check in the template (the hasKey usage around
$config.modules) to perform a case-insensitive match or normalize keys before
checking—for example iterate over the keys of $config.modules and compare
strings lowercased to "gateway" or add a helper/pipe to lower the key before
calling hasKey so the port-forward branch triggers when any case variant of the
gateway module is present.
Dav-14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.