Merge master into dev#4032
Merged
Merged
Conversation
…orcedotcom#4024) Add Login for Admin feature.
…orcedotcom#4028) * Add public API to trigger Login for Admin flow. * Improve code documentation for loginViewControllerDidSelectLoginForAdmin.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4032 +/- ##
==========================================
- Coverage 70.46% 67.49% -2.98%
==========================================
Files 245 245
Lines 21449 21449
==========================================
- Hits 15115 14477 -638
- Misses 6334 6972 +638
🚀 New features to boost your workflow:
|
bbirman
reviewed
May 8, 2026
| /// Performs login via the "Login for Admin" flow. | ||
| /// Taps Settings → "Login for Admin" which triggers ASWebAuthenticationSession (native browser), | ||
| /// then completes authentication in the browser. | ||
| func performLoginForAdmin(username: String, password: String) { |
Member
There was a problem hiding this comment.
It looks like there's another func performLoginForAdmin(username: String, password: String) below this one?
|
||||||||||||||
|
||||||||||||||||
|
||||||||||||||||||
bbirman
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SFSDKAuthSession.m: kept dev's removal of the deprecateduserAgentForAuthblock (removed in PR Remove deprecated code #4020), discarding the master version which still carried it (master received PR Add Login for Admin feature. #4022/login-for-admin as a patch but not Remove deprecated code #4020/remove-deprecations)Test plan