Conversation
Bump to iOS 18 and add corresponding Claude skill
Switch to #Preview macro for SwiftUI views
Update UI Tests for login screen changes.
- Remove SFMobileSyncSyncManager+Instrumentation references from MobileSync.xcodeproj - Remove SFSmartStore+Instrumentation references from SmartStore.xcodeproj Fixes build errors where Xcode was trying to copy deleted header files.
…pport Remove signpost support (W-20481716)
Fix compiler warnings in testLoginHostListViewControllerCreatesUniqueInstances
Add Login for Admin feature.
Remove deprecated code
Update SQLCipher to 4.15.0 and add skill
* Add public API to trigger Login for Admin flow. * Improve code documentation for loginViewControllerDidSelectLoginForAdmin.
Putting back SalesforceSDKCommon
Generated by 🚫 Danger |
|
||||||||||||||
Clang Static Analysis Issues
Generated by 🚫 Danger |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4031 +/- ##
==========================================
+ Coverage 68.90% 70.46% +1.56%
==========================================
Files 260 245 -15
Lines 22515 21449 -1066
==========================================
- Hits 15513 15115 -398
+ Misses 7002 6334 -668
🚀 New features to boost your workflow:
|
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||||||
|
||||||||||||||||||||||||||||
|
||||||||||||||||
|
||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SFSDKAuthSession.m: kept dev's removal of the deprecateduserAgentForAuthblock (removed in PR Remove deprecated code #4020), discarding the master version which still carried it (master received PR Add Login for Admin feature. #4022/login-for-admin as a patch but not Remove deprecated code #4020/remove-deprecations)Test plan