Skip to content

Merge master into dev#4031

Closed
wmathurin wants to merge 31 commits intomasterfrom
dev
Closed

Merge master into dev#4031
wmathurin wants to merge 31 commits intomasterfrom
dev

Conversation

@wmathurin
Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Build SalesforceSDKCore scheme and verify no compile errors
  • Run SalesforceSDKCore test suite

wmathurin and others added 30 commits April 2, 2026 10:37
Bump to iOS 18 and add corresponding Claude skill
Switch to #Preview macro for SwiftUI views
Update UI Tests for login screen changes.
- Remove SFMobileSyncSyncManager+Instrumentation references from MobileSync.xcodeproj
- Remove SFSmartStore+Instrumentation references from SmartStore.xcodeproj

Fixes build errors where Xcode was trying to copy deleted header files.
…pport

Remove signpost support (W-20481716)
Fix compiler warnings in testLoginHostListViewControllerCreatesUniqueInstances
Update SQLCipher to 4.15.0 and add skill
* Add public API to trigger Login for Admin flow.

* Improve code documentation for loginViewControllerDidSelectLoginForAdmin.
Putting back SalesforceSDKCommon
@wmathurin wmathurin closed this May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

1 Error
🚫 Please re-submit this PR to the dev branch, we may have already fixed your issue.
1 Warning
⚠️ Big PR, try to keep changes smaller if you can.

Generated by 🚫 Danger

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ✅SkippedFailed
SalesforceAnalytics iOS ^18 Test Results19 ran19 ✅
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 119 19
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 243 15
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1579 15
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1594 15
SFUserAccountManager Nullability Memory error nil passed to a callee that requires a non-null 2nd parameter 2229 13

Generated by 🚫 Danger

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.46%. Comparing base (a5f82d7) to head (3cdaf5f).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4031      +/-   ##
==========================================
+ Coverage   68.90%   70.46%   +1.56%     
==========================================
  Files         260      245      -15     
  Lines       22515    21449    -1066     
==========================================
- Hits        15513    15115     -398     
+ Misses       7002     6334     -668     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.97% <ø> (+1.22%) ⬆️
Core 65.15% <100.00%> (+2.34%) ⬆️
SmartStore 73.44% <ø> (-1.27%) ⬇️
MobileSync 88.79% <ø> (+1.37%) ⬆️
Files with missing lines Coverage Δ
...rceSDKCore/Classes/Common/SalesforceSDKConstants.h 100.00% <100.00%> (ø)
...sforceSDKCore/Classes/Common/UIDevice+SFHardware.m 4.82% <ø> (ø)
...ceSDKCore/Classes/Common/WebViewStateManager.swift 53.12% <ø> (+6.61%) ⬆️
...forceSDKCore/Classes/Login/SFLoginViewController.m 76.51% <100.00%> (+1.93%) ⬆️
...lesforceSDKCore/Classes/OAuth/SFOAuthCoordinator.m 62.42% <100.00%> (+2.30%) ⬆️
...SalesforceSDKCore/Classes/OAuth/SFSDKAuthSession.m 90.32% <100.00%> (-1.11%) ⬇️
...Classes/Security/ScreenLock/ScreenLockUIView.swift 53.03% <ø> (+1.55%) ⬆️
.../Storage/KeyValueEncryptedFileStoreInspector.swift 0.00% <ø> (ø)
...SDKCore/Classes/UserAccount/SFUserAccountManager.m 61.64% <100.00%> (+1.29%) ⬆️
...KCore/SalesforceSDKCore/Classes/Util/SFSDKOAuth2.m 68.89% <ø> (+0.10%) ⬆️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ✅SkippedFailed
SmartStore iOS ^18 Test Results177 ran177 ✅
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ✅SkippedFailed
SmartStore iOS ^26 Test Results177 ran177 ✅
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ✅SkippedFailed
SalesforceSDKCommon iOS ^26 Test Results40 ran40 ✅
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ✅SkippedFailed
SalesforceAnalytics iOS ^26 Test Results19 ran19 ✅
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ✅SkippedFailed
SalesforceSDKCommon iOS ^18 Test Results40 ran40 ✅
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ✅SkippedFailed
AuthFlowTester UI Test Results all1 ran1 ✅
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results625 ran623 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
LoginOptionsViewControllerTests.testBootConfigPickerViewRendered()❌ failure
SFUserAccountManagerTests.testAuthHandler❌ failure

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^18 Test Results625 ran618 ✅7 ❌
TestResult
SalesforceSDKCore iOS ^18 Test Results
testMissingMyDomain()❌ failure
testSendURLRequestHTTPError()❌ failure
SalesforceRestAPITests.testCreateQuerySearchDelete❌ failure
SalesforceRestAPITests.testCreateUpdateQuerySearchDelete❌ failure
SalesforceRestAPITests.testUpdateWithIfUnmodifiedSince❌ failure
SalesforceRestAPITests.testUploadOwnedFilesDelete❌ failure
SalesforceRestAPITests.testUpsert❌ failure

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ☑️SkippedFailed ❌️
MobileSync iOS ^26 Test Results234 ran233 ✅1 ❌
TestResult
MobileSync iOS ^26 Test Results
SyncManagerTests.testCleanResyncGhostsForMRUTarget❌ failure

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

TestsPassed ☑️SkippedFailed ❌️
MobileSync iOS ^18 Test Results234 ran233 ✅1 ❌
TestResult
MobileSync iOS ^18 Test Results
BriefcaseSyncDownTests.testStartFetchWithMaxTimestamp()❌ failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants