FAT-24610 Implement e2e for C523775#7124
Merged
Merged
Conversation
Daria-Reznikova
requested changes
May 13, 2026
| SATURDAY: 'SATURDAY', | ||
| }, | ||
| DEFAULT_ORDERS_DIRECTORY: '/ftp/files/orders', | ||
| DEFAULT_FTP_PORT: 22, |
Contributor
There was a problem hiding this comment.
Could it be _SFTP_PORT? Because for FTP we usually use 21 port
Contributor
Author
There was a problem hiding this comment.
This naming just refers to the field label
| FRIDAY: 'FRIDAY', | ||
| SATURDAY: 'SATURDAY', | ||
| }, | ||
| DEFAULT_ORDERS_DIRECTORY: '/ftp/files/orders', |
Contributor
There was a problem hiding this comment.
Could it be DEFAULT_SFTP_ORDERS_DIRECTORY because for FTP directory is '/files/orders'
| assertSegmentExists(segments, 'UNH+'); | ||
|
|
||
| cy.log('< --- STEP 5: Check currency displaying --- >'); | ||
| assertCurrencySegments(segments, currencies); |
Contributor
There was a problem hiding this comment.
Could you add a check to verify that there are three currency segments (CUX+2) are present in the exported EDI file? One for the Order and two for POLs.
Comment on lines
+404
to
+405
| cy.log('< --- STEP 7: Check calculation price --- >'); | ||
| assertPriceSegments(segments); |
Contributor
There was a problem hiding this comment.
Could you add a check to ensure that the PRI+AAB segment appears without a currency code?
Daria-Reznikova
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA - https://folio-org.atlassian.net/browse/FAT-24610
TestRail - https://foliotest.testrail.io/index.php?/cases/view/523775