Skip to content

MODSOURMAN-1416: Add post-processing entity types to journal params fo… #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaterynaSenchenko merged 2 commits into from
May 29, 2026
+29 −0
Merged

MODSOURMAN-1416: Add post-processing entity types to journal params fo… #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed7b1f
MODSOURMAN-1416:Add post-processing entity types to journal params fo…
KaterynaSenchenko May 29, 2026
bbbab42
MODSOURMAN-1416: Change entity type for Holdings post processing
KaterynaSenchenko May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...-record-manager-server/src/main/java/org/folio/verticle/consumers/util/JournalParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,22 @@ public Optional<JournalParams> getJournalParams(DataImportEventPayload eventPayl
JournalRecord.ActionStatus.COMPLETED));
}
},
DI_SRS_MARC_AUTHORITY_RECORD_MODIFIED_READY_FOR_POST_PROCESSING { //added for correct processing of DI_ERROR event when Authority record update fails
@Override
public Optional<JournalParams> getJournalParams(DataImportEventPayload eventPayload) {
return Optional.of(new JournalParams(UPDATE,
JournalRecord.EntityType.AUTHORITY,
JournalRecord.ActionStatus.COMPLETED));
}
},
DI_SRS_MARC_HOLDINGS_RECORD_MODIFIED_READY_FOR_POST_PROCESSING { //added for correct processing of DI_ERROR event when Holdings record update fails
@Override
public Optional<JournalParams> getJournalParams(DataImportEventPayload eventPayload) {
return Optional.of(new JournalParams(UPDATE,
JournalRecord.EntityType.HOLDINGS,
JournalRecord.ActionStatus.COMPLETED));
}
},
DI_INVENTORY_INSTANCE_CREATED_READY_FOR_POST_PROCESSING {
@Override
public Optional<JournalParams> getJournalParams(DataImportEventPayload eventPayload) {
Expand Down
13 changes: 13 additions & 0 deletions ...ord-manager-server/src/test/java/org/folio/verticle/consumers/util/JournalParamsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
import static org.folio.rest.jaxrs.model.DataImportEventTypes.DI_INVENTORY_HOLDINGS_UPDATED_READY_FOR_POST_PROCESSING;
import static org.folio.rest.jaxrs.model.DataImportEventTypes.DI_INVENTORY_AUTHORITY_CREATED_READY_FOR_POST_PROCESSING;
import static org.folio.rest.jaxrs.model.DataImportEventTypes.DI_INVENTORY_AUTHORITY_UPDATED_READY_FOR_POST_PROCESSING;
import static org.folio.rest.jaxrs.model.DataImportEventTypes.DI_SRS_MARC_AUTHORITY_RECORD_MODIFIED_READY_FOR_POST_PROCESSING;
import static org.folio.rest.jaxrs.model.DataImportEventTypes.DI_SRS_MARC_HOLDINGS_RECORD_MODIFIED_READY_FOR_POST_PROCESSING;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

Expand Down Expand Up @@ -190,6 +192,17 @@ public void shouldPopulateAuthorityUpdatedErrorParamsWhenEventChainEndsWithDiInv
returnErrorJournalParamsByLastEventInChain(DI_INVENTORY_AUTHORITY_UPDATED_READY_FOR_POST_PROCESSING,
JournalRecord.EntityType.AUTHORITY, JournalRecord.ActionType.UPDATE);
}
@Test
public void shouldPopulateMarcAuthorityUpdatedErrorParamsWhenEventChainEndsWithDiSrsMarcAuthorityRecordModifiedReadyForPostProcessing() {
returnErrorJournalParamsByLastEventInChain(DI_SRS_MARC_AUTHORITY_RECORD_MODIFIED_READY_FOR_POST_PROCESSING,
JournalRecord.EntityType.AUTHORITY, JournalRecord.ActionType.UPDATE);
}

@Test
public void shouldPopulateMarcHoldingsUpdatedErrorParamsWhenEventChainEndsWithDiSrsMarcHoldingsRecordModifiedReadyForPostProcessing() {
returnErrorJournalParamsByLastEventInChain(DI_SRS_MARC_HOLDINGS_RECORD_MODIFIED_READY_FOR_POST_PROCESSING,
JournalRecord.EntityType.HOLDINGS, JournalRecord.ActionType.UPDATE);
}

@Test
public void shouldPopulateEntityTypeMarcAuthorityWhenEventTypeIsDiCompleted() {
Expand Down
Loading