Skip to content

fix: add missing data to request payloads to save hideArchived value#790

Merged
smarcet merged 1 commit intomasterfrom
fix/sponsor-forms-tab-hide-archived
Feb 11, 2026
Merged

fix: add missing data to request payloads to save hideArchived value#790
smarcet merged 1 commit intomasterfrom
fix/sponsor-forms-tab-hide-archived

Conversation

@tomrndom
Copy link

@tomrndom tomrndom commented Feb 11, 2026

ref: https://app.clickup.com/t/86b87mme8

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • New Features
    • Added an option to hide archived sponsor forms on the Sponsor Forms tab, available for both Managed and Customized lists. This helps focus on active forms during browsing, searching, sorting, and pagination.
    • When enabled, the view filters out archived entries, reducing clutter and streamlining form management.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet February 11, 2026 15:19
@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This PR adds the hideArchived parameter to two sponsor form API request calls in the actions file and removes variable destructuring from the form tab component's sort handler. The changes affect how sponsor forms are fetched and sorted by filtering archived forms and adjusting variable resolution in the component.

Changes

Cohort / File(s) Summary
API Parameter Enhancement
src/actions/sponsor-forms-actions.js
Added hideArchived parameter to both getSponsorManagedForms and getSponsorCustomizedForms API request payloads to enable filtering of archived forms.
Component Variable Resolution
src/pages/sponsors/sponsor-forms-tab/index.js
Removed destructuring of currentPage and perPage variables from customizedForms in the handleCustomizedSort function, potentially altering variable resolution scope.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • smarcet

Poem

🐰 A filter for forms archived away,
And variables set for the light of day,
Pagination flows with a curious twist,
Hidden forms now can't be missed!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding hideArchived parameter to API request payloads in sponsor forms actions to persist the hideArchived value.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sponsor-forms-tab-hide-archived

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 03d4aef into master Feb 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants