Skip to content

Run go fix as part of make test and CI - #2190

Merged
matheuscscp merged 1 commit into
fluxcd:mainfrom
andrearcaina:ci/go-fix-modernization
Nov 14, 2026
Merged

matheuscscp merged 1 commit into
fluxcd:mainfrom
andrearcaina:ci/go-fix-modernization

Conversation

@andrearcaina

Copy link
Copy Markdown

Part of fluxcd/flux2#6120

  • Applies go fix ./... changes to the root and api directory
  • Run go fix ./... as part of make test command

Validation:

  • make test-api passes
  • make test ran into some local OCI failures for me

@matheuscscp matheuscscp added the hold Issues and pull requests put on hold label Oct 19, 2026
@matheuscscp

Copy link
Copy Markdown
Member

Hey @andrearcaina thanks again! I'm gonna hold this PR and any others related to this issue for a couple of weeks. We are about to release Flux 2.10 in one week, and since the go fix changes are quite massive (despite hopefully harmless 🤞) I prefer to reduce the release risk.

@andrearcaina

Copy link
Copy Markdown
Author

Hey @matheuscscp, no worries! Good luck with the release!

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
matheuscscp force-pushed the ci/go-fix-modernization branch from 092a190 to 192e64d Compare November 14, 2026 14:19
@matheuscscp matheuscscp added area/ci CI related issues and pull requests and removed hold Issues and pull requests put on hold labels Nov 14, 2026

@matheuscscp matheuscscp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@matheuscscp
matheuscscp merged commit 020a7b9 into fluxcd:main Nov 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants