Repository navigation
[material_ui] Add Material 3 Expressive FilledButton and Filled tonal button (FilledButton.tonal) - #13702
Draft
QuncCccccc wants to merge 3 commits into
Draft
[material_ui] Add Material 3 Expressive FilledButton and Filled tonal button (FilledButton.tonal)#13702QuncCccccc wants to merge 3 commits into
FilledButton and Filled tonal button (FilledButton.tonal)#13702QuncCccccc wants to merge 3 commits into
Conversation
FilledButtonFilledButton and Filled tonal button (FilledButton.tonal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Material 3 Expressive support to
FilledButton, includingFilledButton.tonal. As withElevatedButton(#13084), apps opt in withFilledButtonThemeData(variant: StyleVariant.material3Expressive). Without it,FilledButtonkeeps the Material 3 style.With Material 3 Expressive, filled and filled tonal buttons support:
ButtonStyle.sizeVariant): extra small through extra large. Each size has its own height, padding, icon size, label text style, and gap between the icon and the label.ButtonStyle.shapeVariant): round and square, including the pressed shape and the shape change when a toggle button is selected.isSelectedis selectable, and uses the selected colors and selected semantics whenisSelectedis true.The defaults are generated from the Material Design tokens by
ButtonTemplateM3E, which #13684 updates to support all the common buttons.New APIs:
FilledButtonThemeData.variantandFilledButtonTheme.variantOf. A theme that doesn't specifyvariantinherits it from the enclosing themes, the same way asElevatedButtonThemeData.variant.isSelectedfor all fourFilledButtonconstructors.sizeVariantandshapeVariantparameters forFilledButton.styleFrom.FilledButtonFilledButton.tonalThis PR depends on #13684. The generated defaults in this PR come from the template changes in that PR, so until #13684 lands, running
gen_defaultson this branch fails atButtonTemplateM3E('Filled Button'), because the template on main only supportsElevatedButton. The code and tests in this PR don't depend on #13684. I'll rebase this PR once #13684 lands.Part of flutter/flutter#184937
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2