Add Static analysis tool written in dart that checks for skill compliance with the open skills specification. - #57
Merged
Conversation
reidbaker
marked this pull request as draft
April 1, 2026 20:00
Contributor
Author
|
/gemini review |
reidbaker
marked this pull request as ready for review
April 3, 2026 14:08
jwren
approved these changes
Apr 6, 2026
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a static analysis linter for Agent Skills, including the core validation engine, CLI entry point, and configuration parsing logic. The review feedback highlights concerns regarding the mutation of global state within the CheckType objects during configuration parsing and rule resolution, suggesting a shift toward immutable configuration objects. Additionally, there is a recommendation to improve the robustness of the YAML frontmatter parsing by moving away from reliance on a single global regular expression.
| @visibleForTesting | ||
| static const maxCompatibilityLength = 500; | ||
|
|
||
| static final _skillStartRegex = RegExp(r'^---\s*\n(.*?)\n---\s*\n', dotAll: true); |
Contributor
There was a problem hiding this comment.
Contributor
Author
|
Confirmed in chat that johnpryan says not to wait for the second review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design doc (googler only) go/flutter-dart-skills-lint-publish-plan
Fixes: #59
Review overview:
Finally any advice you have to make this code more maintainable moving forward. How to integrate it into your cicd etc. I think ci changes should go into a second pr but it may still be valuable to talk about it here.
Features that need to be added.
Ignores for -d so that .dart_tool and other directories can be ignored.
Pre-launch Checklist
///).