Skip to content

Ignore .claude/ and pubspec.lock - #118

Merged
reidbaker merged 1 commit into
mainfrom
r-git-ignore-claude-pubspec
May 5, 2026
Merged

reidbaker merged 1 commit into
mainfrom
r-git-ignore-claude-pubspec

Conversation

@reidbaker

@reidbaker reidbaker commented May 5, 2026 •

Copy link
Copy Markdown
Contributor
  • Add .claude/ and pubspec.lock to .gitignore

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to exclude pubspec.lock and the .claude/ directory. Feedback suggests that pubspec.lock should be tracked rather than ignored to ensure reproducible builds for the application, and recommends adding pubspec_overrides.yaml to the ignore list instead.

Comment thread .gitignore
# https://dart.dev/guides/libraries/private-files
# Created by `dart pub`
.dart_tool/
pubspec.lock

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Dart guide linked at the top of this file recommends committing pubspec.lock for applications and workspaces to ensure reproducible builds across different environments. Since this repository contains a command-line application (tool/generator), it is better to commit the lock file. However, you should ignore pubspec_overrides.yaml, as it contains local environment overrides that can break the build for other contributors if committed.

pubspec_overrides.yaml

@reidbaker
reidbaker merged commit 79ac38c into main May 5, 2026
2 checks passed
@reidbaker
reidbaker deleted the r-git-ignore-claude-pubspec branch May 5, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant