Skip to content

workflows: Unify steps of downloading built macOS packages#11666

Merged
edsiper merged 1 commit intomasterfrom
cosmo0920-unify-downloading-macOS-packages-from-artifacts
Apr 7, 2026
Merged

workflows: Unify steps of downloading built macOS packages#11666
edsiper merged 1 commit intomasterfrom
cosmo0920-unify-downloading-macOS-packages-from-artifacts

Conversation

@cosmo0920
Copy link
Copy Markdown
Contributor

@cosmo0920 cosmo0920 commented Apr 3, 2026

In the steps of package creations for macOS and Windows, there's a glitch for assumed locations which should be handled as unified artifacts.
So, we need to use unified way to handle uploading macOS packages correctly.

ref: The steps of Windows installers creations is here:
https://github.com/fluent/fluent-bit/blob/master/.github/workflows/call-build-windows.yaml#L272C1-L302C32

Related to #11658.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 marked this pull request as ready for review April 3, 2026 09:37
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

📝 Walkthrough

Walkthrough

The macOS build workflow's artifact handling is refactored: artifact naming changed from space-based to dash-based convention, the S3 upload job's matrix strategy is removed, and artifact downloads now use pattern matching to consolidate multiple artifacts into a single directory with explicit validation.

Changes

Cohort / File(s) Summary
MacOS Build Workflow Artifact Handling
.github/workflows/call-build-macos.yaml
Renamed artifacts from macos-packages on ${{ matrix.config.runner }} to macos-packages-${{ matrix.config.runner }}. Removed strategy.matrix from S3 upload job. Changed artifact download to use actions/download-artifact with pattern: macos-packages-* and merge-multiple: true. Added validation step with ls -lR artifacts/.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

docs-required

Suggested reviewers

  • niedbalski
  • patrick-stephens
  • celalettin1286

Poem

🐰 A rabbit hops through workflow trails,
With artifacts that never fail,
Dashes replace the spaces now,
macOS packages take a bow!
Pattern merging, swift and true,
Releases fixed—validation through! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR changes implement unified artifact downloading for macOS packages as required to fix missing macOS releases (issue #11658), addressing the core objective through workflow modifications.
Out of Scope Changes check ✅ Passed All changes are scoped to the macOS workflow artifact handling (renaming, download pattern, and validation step) and directly address the linked issue objective of fixing macOS package uploads.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The pull request title 'workflows: Unify steps of downloading built macOS packages' directly summarizes the main change: unifying the artifact download approach for macOS packages in GitHub Actions workflows.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-unify-downloading-macOS-packages-from-artifacts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cosmo0920 cosmo0920 changed the title workflows: Unify downloading built macOS packages workflows: Unify steps of downloading built macOS packages Apr 3, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/call-build-macos.yaml:
- Around line 140-143: The "Validate downloaded artifacts" step currently only
lists artifacts and should be hardened to fail when no package files exist;
update the step (named "Validate downloaded artifacts") to run a check that
searches artifacts/ for expected package patterns (e.g., *.pkg, *.dmg, *.tar.gz)
and exit non‑zero if none are found—use a simple existence test (find with -name
or ls -A) and return a failing status when the search finds zero matches so the
workflow fails on empty payloads.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 045b4e5f-f0e0-4dd8-8678-b383883413b7

📥 Commits

Reviewing files that changed from the base of the PR and between 3e414ac and 6c9c54d.

📒 Files selected for processing (1)
  • .github/workflows/call-build-macos.yaml

@edsiper edsiper merged commit 17e1d93 into master Apr 7, 2026
17 checks passed
@edsiper edsiper deleted the cosmo0920-unify-downloading-macOS-packages-from-artifacts branch April 7, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants