workflows: Unify steps of downloading built macOS packages#11666
workflows: Unify steps of downloading built macOS packages#11666
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
📝 WalkthroughWalkthroughThe macOS build workflow's artifact handling is refactored: artifact naming changed from space-based to dash-based convention, the S3 upload job's matrix strategy is removed, and artifact downloads now use pattern matching to consolidate multiple artifacts into a single directory with explicit validation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/call-build-macos.yaml:
- Around line 140-143: The "Validate downloaded artifacts" step currently only
lists artifacts and should be hardened to fail when no package files exist;
update the step (named "Validate downloaded artifacts") to run a check that
searches artifacts/ for expected package patterns (e.g., *.pkg, *.dmg, *.tar.gz)
and exit non‑zero if none are found—use a simple existence test (find with -name
or ls -A) and return a failing status when the search finds zero matches so the
workflow fails on empty payloads.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 045b4e5f-f0e0-4dd8-8678-b383883413b7
📒 Files selected for processing (1)
.github/workflows/call-build-macos.yaml
In the steps of package creations for macOS and Windows, there's a glitch for assumed locations which should be handled as unified artifacts.
So, we need to use unified way to handle uploading macOS packages correctly.
ref: The steps of Windows installers creations is here:
https://github.com/fluent/fluent-bit/blob/master/.github/workflows/call-build-windows.yaml#L272C1-L302C32
Related to #11658.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.