Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDocumentation-only update: the S3 output plugin Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/s3.md`:
- Line 82: The doc for retry_limit on the S3 plugin is contradictory; update the
wording for the `retry_limit` field to first state the default when unset
(default: 5) and then provide an explicit mapping for explicit values:
`no_limits` → unlimited retries, `no_retries` → disable retries, and treat
`false`/`off` as aliases for disabling retries (or mark them as deprecated
aliases if desired). Mention that the default 5 avoids wasting partially
uploaded multipart data and keep the examples/column value as `5`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
The S3 plugin now defaults retry_limit to 5 when not explicitly set, since the engine default of 1 is too low for S3's internal retry system. Signed-off-by: Anuj Singh <singholt@amazon.com>
789c274 to
41fa3b5
Compare
github.com/fluent/fluent-bit/pull/11669
Summary by CodeRabbit
retry_limitdocs: default changed to 5; clarifies accepted values are an integer retry count orno_retriesto disable; removed prior general/ambiguous disable options; notes retries are handled by the plugin’s internal retry system (separate from Fluent Bit’s general mechanisms).