Skip to content

s3: update retry_limit default to 5#2536

Open
singholt wants to merge 1 commit intofluent:masterfrom
singholt:docs/s3-retry-limit-default
Open

s3: update retry_limit default to 5#2536
singholt wants to merge 1 commit intofluent:masterfrom
singholt:docs/s3-retry-limit-default

Conversation

@singholt
Copy link
Copy Markdown
Contributor

@singholt singholt commented Apr 3, 2026

github.com/fluent/fluent-bit/pull/11669

Summary by CodeRabbit

  • Documentation
    • Updated S3 plugin retry_limit docs: default changed to 5; clarifies accepted values are an integer retry count or no_retries to disable; removed prior general/ambiguous disable options; notes retries are handled by the plugin’s internal retry system (separate from Fluent Bit’s general mechanisms).

@singholt singholt requested review from a team and eschabell as code owners April 3, 2026 17:52
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6cf54d1f-68e1-4aef-bdc0-4bcc045a30f0

📥 Commits

Reviewing files that changed from the base of the PR and between 789c274 and 41fa3b5.

📒 Files selected for processing (1)
  • pipeline/outputs/s3.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • pipeline/outputs/s3.md

📝 Walkthrough

Walkthrough

Documentation-only update: the S3 output plugin retry_limit entry in pipeline/outputs/s3.md now describes retries as part of the plugin’s internal retry/buffering system, changes the documented default from 1 to 5, and narrows accepted values to an integer count or no_retries to disable retries.

Changes

Cohort / File(s) Summary
S3 Configuration Documentation
pipeline/outputs/s3.md
Rewrote the retry_limit description to state retries are handled by the S3 plugin's internal retry/buffering system, updated the default from 1 to 5, and clarified accepted values: integer retry count or no_retries to disable retries (removed prior references to no_limits/false/off).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 With hops and notes I write,
Five retries now take flight,
Internal buffers hum along,
Clearer docs to sing this song. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly summarizes the main change: updating the S3 plugin's retry_limit default value to 5, which is the primary objective of this documentation update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pipeline/outputs/s3.md`:
- Line 82: The doc for retry_limit on the S3 plugin is contradictory; update the
wording for the `retry_limit` field to first state the default when unset
(default: 5) and then provide an explicit mapping for explicit values:
`no_limits` → unlimited retries, `no_retries` → disable retries, and treat
`false`/`off` as aliases for disabling retries (or mark them as deprecated
aliases if desired). Mention that the default 5 avoids wasting partially
uploaded multipart data and keep the examples/column value as `5`.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3aa76126-c6ae-48e8-a5fe-a93bb03f9005

📥 Commits

Reviewing files that changed from the base of the PR and between 3da2d5f and 789c274.

📒 Files selected for processing (1)
  • pipeline/outputs/s3.md

The S3 plugin now defaults retry_limit to 5 when not explicitly
set, since the engine default of 1 is too low for S3's internal
retry system.

Signed-off-by: Anuj Singh <singholt@amazon.com>
@singholt singholt force-pushed the docs/s3-retry-limit-default branch from 789c274 to 41fa3b5 Compare April 3, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant