docs: installation: downloads: macos: removed missing package link#2526
docs: installation: downloads: macos: removed missing package link#2526eschabell wants to merge 1 commit intofluent:masterfrom
Conversation
- no longer building macos package Applies to fluent#2390 Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughUpdated macOS installation documentation link from a non-existent macOS-specific package path to the root packages repository. This is a straightforward URL correction addressing a broken documentation link. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@installation/downloads/macos.md`:
- Line 7: Update the sentence "Installation packages can be found [in the Fluent
Bit repository](https://packages.fluentbit.io/)." to clearly state that no
official macOS packages are currently published and remove or disable the
misleading repository link; for example replace that line with a neutral
statement indicating macOS packages are not built/published and, if applicable,
point users to source build instructions or Homebrew alternatives. Ensure the
new wording is technical and neutral (no marketing tone) and locate/modify the
exact sentence in macos.md.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ec728b9f-9aec-4966-8eab-cb2109d1e234
📒 Files selected for processing (1)
installation/downloads/macos.md
|
@patrick-stephens ready for review! |
|
We do build them @eschabell, or should do, I think @hiroshi was looking at an issue though for 5.0. The problem is more there is no index so it needs linking directly to the version like we do for Windows (and we update via the update-version.sh script in CI). |
|
@patrick-stephens this is what we get on that URL for some time: |
|
Yeah I mean you have to go to the specific URL for the package version you want, like we link in Windows docs. There is no index page which is what that error basically says, we used to get one due to the use of nginx I think on the bare metal server |
|
@patrick-stephens so should I close this PR as rejected / invalid? |
|
I would update it with the details of how to get the link you want, which should be something like: Where:
e.g. https://packages.fluentbit.io/macos/fluent-bit-3.0.4-apple.pkg The script called by the Fluent Bit release automatically updates the Windows URLs so we can extend it to do the macOS ones as well: https://github.com/fluent/fluent-bit-docs/blob/master/update-release-version-docs.sh Unfortunately it looks like macOS builds have not been copied for a while: https://github.com/fluent/fluent-bit/actions/runs/23863425387/job/69576187010 |
Applies to #2390
Summary by CodeRabbit