Skip to content

docs: installation: downloads: macos: removed missing package link#2526

Open
eschabell wants to merge 1 commit intofluent:masterfrom
eschabell:erics_macos_package_fix
Open

docs: installation: downloads: macos: removed missing package link#2526
eschabell wants to merge 1 commit intofluent:masterfrom
eschabell:erics_macos_package_fix

Conversation

@eschabell
Copy link
Copy Markdown
Collaborator

@eschabell eschabell commented Mar 30, 2026

  • no longer building macos package

Applies to #2390

Summary by CodeRabbit

  • Documentation
    • Updated macOS installation documentation with revised package repository link.

  - no longer building macos package

  Applies to fluent#2390

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Mar 30, 2026
@eschabell eschabell requested a review from a team as a code owner March 30, 2026 11:27
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0 labels Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

Updated macOS installation documentation link from a non-existent macOS-specific package path to the root packages repository. This is a straightforward URL correction addressing a broken documentation link.

Changes

Cohort / File(s) Summary
Documentation Link Update
installation/downloads/macos.md
Modified "Installation packages" hyperlink from https://packages.fluentbit.io/macos/ to https://packages.fluentbit.io/ to resolve broken link reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Suggested reviewers

  • patrick-stephens
  • cosmo0920

Poem

🐰 A link was broken, oh what a sight,
But this fluffy fixer made it right!
From /macos/ to the root we go,
Documentation now has proper flow! 📦✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'removed missing package link', but the actual change links 'Installation packages' to the root repository rather than removing the link. The title is misleading about the nature of the change. Revise the title to accurately reflect the change, such as 'docs: installation: downloads: macos: update package link to repository root' or 'docs: installation: downloads: macos: redirect package link from macOS path to root'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@installation/downloads/macos.md`:
- Line 7: Update the sentence "Installation packages can be found [in the Fluent
Bit repository](https://packages.fluentbit.io/)." to clearly state that no
official macOS packages are currently published and remove or disable the
misleading repository link; for example replace that line with a neutral
statement indicating macOS packages are not built/published and, if applicable,
point users to source build instructions or Homebrew alternatives. Ensure the
new wording is technical and neutral (no marketing tone) and locate/modify the
exact sentence in macos.md.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ec728b9f-9aec-4966-8eab-cb2109d1e234

📥 Commits

Reviewing files that changed from the base of the PR and between c7214d5 and 2b48cef.

📒 Files selected for processing (1)
  • installation/downloads/macos.md

@eschabell
Copy link
Copy Markdown
Collaborator Author

@patrick-stephens ready for review!

@patrick-stephens
Copy link
Copy Markdown
Contributor

We do build them @eschabell, or should do, I think @hiroshi was looking at an issue though for 5.0. The problem is more there is no index so it needs linking directly to the version like we do for Windows (and we update via the update-version.sh script in CI).

@eschabell eschabell added 5.0.2 and removed 5.0 labels Apr 1, 2026
@eschabell
Copy link
Copy Markdown
Collaborator Author

eschabell commented Apr 1, 2026

@patrick-stephens this is what we get on that URL for some time:

<Error>
<Code>NoSuchKey</Code>
<Message>The specified key does not exist.</Message>
<Key>macos/</Key>
<RequestId>SZBMDJCAQ4BWF4H4</RequestId>
<HostId>RWmXekqUI66iFq7sCwKIQEddwA9JF753MM2W6eGhCwf4lN/fHT9KIz0yaEN3SRIQN/A3PkAMc9mLvYShDFux8bJLyCSih+3l</HostId>
</Error>

@patrick-stephens
Copy link
Copy Markdown
Contributor

Yeah I mean you have to go to the specific URL for the package version you want, like we link in Windows docs. There is no index page which is what that error basically says, we used to get one due to the use of nginx I think on the bare metal server

@eschabell
Copy link
Copy Markdown
Collaborator Author

@patrick-stephens so should I close this PR as rejected / invalid?

@patrick-stephens
Copy link
Copy Markdown
Contributor

patrick-stephens commented Apr 2, 2026

I would update it with the details of how to get the link you want, which should be something like: https://packages.fluentbit.io/macos/fluent-bit-<version>-<arch>.pkg

Where:

  • version is the numeric release value, e.g. 3.0.4
  • arch is either apple or intel

e.g. https://packages.fluentbit.io/macos/fluent-bit-3.0.4-apple.pkg

The script called by the Fluent Bit release automatically updates the Windows URLs so we can extend it to do the macOS ones as well: https://github.com/fluent/fluent-bit-docs/blob/master/update-release-version-docs.sh

Unfortunately it looks like macOS builds have not been copied for a while: https://github.com/fluent/fluent-bit/actions/runs/23863425387/job/69576187010
Raised fluent/fluent-bit#11658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0.2 waiting-on-review Waiting on a review from mainteners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants