pipeline: outputs: cloudwatch: Add StorageResolution Support#1691
pipeline: outputs: cloudwatch: Add StorageResolution Support#1691devin-andrenam wants to merge 4 commits intofluent:masterfrom
Conversation
Signed-off-by: Devin Stafford <devin@andrenam.com>
devin-andrenam
force-pushed
the
devin/update-docs-storage-resolution-emf
branch
from
dffc58f to
f5dff74
Compare
esmerel
left a comment
esmerel
left a comment
There was a problem hiding this comment.
Minor stylistic change. A @fluent/fluent-bit-maintainers should doublecheck the definition for technical accuracy, but I'm otherwise ok with this.
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
eschabell
added
waiting-for-user
|
@devin-andrenam while waiting on the code PR changes fluent/fluent-bit#10398 you need to make, would you please fix the conflicts here so I'm ready to merge your docs update when we can? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
Conflict was due to formatting changes for style. I reverified so the submitter doesn't need to. |
esmerel
removed
conflict
|
There are on changes? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
Appears I overwrote the change fixing the conflict, I corrected it. I was afraid I'd done that at least once. |
eschabell
added
4.2.1
conflict
|
@devin-andrenam there are still conflicts here that need to be addressed, not sure if @esmerel needs to look at this as she was working on this too? |
eschabell
left a comment
eschabell
left a comment
There was a problem hiding this comment.
This has too many backticks:
`metric`_storage_resolution`
5 participants
Documentation update in association with according PR to fluent bit.