feat: support non-semver versions in the yarn packager, for example 'github:' references#478
Open
flipscholtz wants to merge 2 commits intofloydspace:masterfrom
Open
feat: support non-semver versions in the yarn packager, for example 'github:' references#478flipscholtz wants to merge 2 commits intofloydspace:masterfrom
flipscholtz wants to merge 2 commits intofloydspace:masterfrom
Conversation
…github:' references
Owner
|
Hi @flipscholtz . I run the tests for the feature, and they failed, could have a look |
Author
Hi @floydspace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support non-semver versions in the yarn packager, for example 'github:' references, when their parent package is marked 'external'.
Issue here
<name>@<semver>. Use a regex that also returns the correct package name for this format:(The last
@in this case is part of the URL and does not denote the boundary between package name and version).I verified this fixes the problem in my minimal test repo here, but I'm not sure if this will have unintended side effects. Needs further testing.