Simplify the code for the battery's time remaining#1948
Open
ponjadito23 wants to merge 2 commits intoflightlessmango:masterfrom
Open
Simplify the code for the battery's time remaining#1948ponjadito23 wants to merge 2 commits intoflightlessmango:masterfrom
ponjadito23 wants to merge 2 commits intoflightlessmango:masterfrom
Conversation
Removes the 'Time Remaining' label and instead uses "REM" as a suffix. Also fixes flightlessmango#1162
As is no longer used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I rewrote the code responsible for displaying the battery's time remaining in a way that is more consistent with the rest of the code.
It removes the 'Time Remaining' label and instead uses the 'REM' suffix, which I find clear enough.
I did this to fix a bug that overlaps text when using compact mode.
It also fixes #1162.
I'm open to suggestions.