Skip to content

params: add Z2E to known handheld GPUs#1837

Open
matte-schwartz wants to merge 1 commit intoflightlessmango:masterfrom
matte-schwartz:matts/z2e
Open

params: add Z2E to known handheld GPUs#1837
matte-schwartz wants to merge 1 commit intoflightlessmango:masterfrom
matte-schwartz:matts/z2e

Conversation

@matte-schwartz
Copy link
Copy Markdown
Contributor

gets rid of the extra unused fields for the Z2E (Strix/890m) similar to the other Z-series chips and Vangogh when using the "full" layout

Before:

image

After:

image

@flightlessmango
Copy link
Copy Markdown
Owner

I wonder if we can figure this out programmatically instead.
If these fields aren't available they should report 0xffff like we check here [src/amdgpu.cpp:L21](https://github.com/flightlessmango/MangoHud/blob/5399bf1a184ce41ff55125e4a24b978392025d24/src/amdgpu.cpp#L73C1-L73C61)

@matte-schwartz
Copy link
Copy Markdown
Contributor Author

that does sound smarter, I think all of them except for gpu_voltage report as 0xffff (gpu_voltage reports as 0). I can try implementing something based off your idea instead.

@flightlessmango
Copy link
Copy Markdown
Owner

Seems safe to assume 0 for voltage also means unavailable

@matte-schwartz
Copy link
Copy Markdown
Contributor Author

sorry, haven't forgotten this. will work on it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants