Skip to content

Make spotlight session caching consistent with server #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielnaab merged 1 commit into from
Oct 10, 2025
Merged

Make spotlight session caching consistent with server #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/spotlight/src/features/form-page/store/actions/initialize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export type Initialize = (

export const initialize: Initialize = (ctx, opts) => {
// Get the session ID from local storage so we can use it on page reload.
const sessionId = window.localStorage.getItem('form_session_id') || undefined;
const sessionId = window.localStorage.getItem(`form_session_id_${opts.formId}`) || undefined;
getFormSession(ctx, {
formId: opts.formId,
route: opts.route,
Expand Down
2 changes: 1 addition & 1 deletion apps/spotlight/src/features/form-page/store/actions/on-submit-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const onSubmitForm: OnSubmitForm = async (ctx, opts) => {
sessionId: submission.data.sessionId,
},
});
window.localStorage.setItem('form_session_id', submission.data.sessionId);
window.localStorage.setItem(`form_session_id_${opts.formId}`, submission.data.sessionId);
} else {
console.error(submission.error);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/server/src/pages/forms/[id].test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ const submitForm = async (
request: new Request(`http://localhost/forms/${formId}`, {
method: 'POST',
body: formData,
headers: sessionId ? { Cookie: `form_session_id=${sessionId}` } : {},
headers: sessionId ? { Cookie: `form_session_id_${formId}=${sessionId}` } : {},
}),
});

Expand Down