Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The OEM sysext is undiscoverable in its current path, and Afterburn activation conditions do not match the generated GRUB arguments.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds Flatcar Outscale support across image generation, OEM metadata, Ignition, Afterburn, hostname, and SSH-key provisioning.
Changes:
- Adds Outscale Ignition and Afterburn provider patches.
- Registers compressed qcow2 image generation and OEM configuration.
- Adds Outscale boot-time metadata integrations.
| File | Summary |
|---|---|
sdk_container/src/third_party/coreos-overlay/sys-kernel/bootengine/bootengine-0.0.38-r50.ebuild |
Bootengine package definition. |
sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/ignition-2.27.0-r1.ebuild |
Ignition package definition. |
sdk_container/src/third_party/coreos-overlay/coreos/user-patches/sys-kernel/bootengine/0001-hostname-set-hostname-from-Outscale-metadata.patch |
Adds Outscale hostname handling. |
sdk_container/src/third_party/coreos-overlay/coreos/user-patches/sys-apps/ignition/2296.patch |
Adds the Ignition Outscale provider. |
sdk_container/src/third_party/coreos-overlay/coreos/user-patches/coreos-base/coreos-init/0001-sshkeys-add-Outscale-support.patch |
Adds Outscale SSH-key handling. |
sdk_container/src/third_party/coreos-overlay/coreos/user-patches/coreos-base/afterburn/1297.patch |
Adds the Afterburn Outscale provider; hostname and SSH-key activation conditions require correction. |
sdk_container/src/third_party/coreos-overlay/coreos-base/oem-oraclecloud/oem-outscale-0.ebuild |
Defines the Outscale OEM sysext; it must be moved to the Outscale directory and accompanied by a changelog entry. |
sdk_container/src/third_party/coreos-overlay/coreos-base/coreos-init/coreos-init-0.0.1-r209.ebuild |
CoreOS init package definition. |
sdk_container/src/third_party/coreos-overlay/coreos-base/afterburn/files/coreos-metadata.service |
Enables the metadata service. |
sdk_container/src/third_party/coreos-overlay/coreos-base/afterburn/afterburn-5.10.0-r4.ebuild |
Afterburn package definition. |
build_library/vm_image_util.sh |
Registers Outscale image generation. |
build_library/oem/outscale/grub.cfg |
Sets the Outscale OEM identifier. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| EAPI=8 | ||
|
|
||
| DESCRIPTION="OEM suite for Outscale" |
b5800c1 to
1be5005
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Outscale images use unsupported compression, and required changelog entries are missing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
Resolved since last review (1)
| ## Outscale | ||
| IMG_outscale_DISK_FORMAT=qcow2 | ||
| IMG_outscale_DISK_LAYOUT=vm | ||
| IMG_outscale_OEM_SYSEXT=outscale |
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
52c0be4 to
2f7412b
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Several critical issues remain, including stale distfile manifests and patches that would fail or be applied twice to live ebuilds, so the change is not yet verifiable or buildable.
7 open issues
Avoid applying the Afterburn patch to the live ebuild · New Avoid applying the Ignition patch to the live ebuild · New Regenerate the bootengine Manifest for the new source · New Use gzip or no compression for OUTSCALE image artifacts Match the legacy Outscale OEM key for hostname setup · New Use the Afterburn PR 1321 patch · New Add a changelog entry for Outscale support
Review effort: Lite
| @@ -0,0 +1,334 @@ | |||
| From 716b1359dbfb40334c631681d53dbf18be78979f Mon Sep 17 00:00:00 2001 | |||
| @@ -0,0 +1,97 @@ | |||
| From 15704d0fe341605f97d978c5e8ca9fee8edf5aa0 Mon Sep 17 00:00:00 2001 | |||
| inherit git-r3 | ||
| else | ||
| EGIT_VERSION="7727ec78da72e700e8fa1ce2144cb2476448d186" # flatcar-master | ||
| EGIT_VERSION="d22a111e9c703c94f4e92466c37d2665a937c702" # flatcar-master |
| ConditionKernelCommandLine=|ignition.platform.id=ibmcloud | ||
| ConditionKernelCommandLine=|ignition.platform.id=kubevirt | ||
| ConditionKernelCommandLine=|ignition.platform.id=oraclecloud | ||
| +ConditionKernelCommandLine=|ignition.platform.id=outscale |
| From 716b1359dbfb40334c631681d53dbf18be78979f Mon Sep 17 00:00:00 2001 | ||
| From: Mohammad AMLA <mohammad.amla@numspot.com> | ||
| Date: Wed, 12 Aug 2026 17:11:31 +0200 | ||
| Subject: [PATCH] providers: Add Outscale support |
There was a problem hiding this comment.
🔵 Needs a closer look
An active nit remains because the Outscale enhancement lacks the required dated changelog entry and its checklist item is still unchecked.
7 open issues
Regenerate the bootengine Manifest for the new source Avoid applying the Ignition patch to the live ebuild Avoid applying the Afterburn patch to the live ebuild Use gzip or no compression for OUTSCALE image artifacts Match the legacy Outscale OEM key for hostname setup Use the Afterburn PR 1321 patch Add a changelog entry for Outscale support
Review effort: Lite
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
All patches applied correctly - thanks to regular updates. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
3f0ed1b to
d0b0100
Compare
There was a problem hiding this comment.
🟡 Changes recommended
An active moderate issue prevents approval because the Outscale image is generated with the wrong extension for direct import, and the change also lacks a release-note entry for the new platform.
8 open issues
Regenerate the bootengine Manifest for the new source Avoid applying the Ignition patch to the live ebuild Avoid applying the Afterburn patch to the live ebuild Use gzip or no compression for OUTSCALE image artifacts Publish Outscale images with the required qcow2.gz extension · New Match the legacy Outscale OEM key for hostname setup Use the Afterburn PR 1321 patch Add a changelog entry for Outscale support
Review effort: Lite
| IMG_outscale_DISK_FORMAT=qcow2 | ||
| IMG_outscale_DISK_LAYOUT=vm | ||
| IMG_outscale_OEM_SYSEXT=outscale |
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
There was a problem hiding this comment.
🔵 Needs a closer look
An active moderate issue remains because Outscale artifacts use a misleading .img.gz extension instead of the required .qcow2.gz format.
8 open issues
Regenerate the bootengine Manifest for the new source Avoid applying the Ignition patch to the live ebuild Avoid applying the Afterburn patch to the live ebuild Use gzip or no compression for OUTSCALE image artifacts Publish Outscale images with the required qcow2.gz extension Match the legacy Outscale OEM key for hostname setup Use the Afterburn PR 1321 patch Add a changelog entry for Outscale support
Review effort: Lite



In this PR, we provide Flatcar Outscale support. This pull Ignition 2.28.0 for Outscale support and a downstream patch for Afterburn (merged upstream but not released):
According to Outscale documentation, it seems we need to import
qcow2compressed image: https://docs.outscale.com/en/userguide/Manifest-File-Reference.htmlRelated to: flatcar/Flatcar#2334
Testing done
Successfully tested on Outscale: flatcar/Flatcar#2334 (comment)
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.This needs: