fix: tidy optional-dependency handling in core (0.4.0)#15
Merged
Conversation
Release this as 0.4.0 (minor bump): the compileOnly dependency change is breaking for integrators, so a patch (0.3.1) understates the impact. - Make WorkManagerUtils.isInitialized internal and drop the unused getWorkManagerOrNull helper, so neither leaks into the public API. - Remove the now-unused androidx.work.WorkManager imports from ProcessLifecycleCallback and DatadogExceptionHandler. - Use the imported Log.e instead of a fully-qualified call in Datadog. - Translate WorkManagerUtils comments to English and add a trailing newline. - Regenerate the core API surface baselines accordingly. - Bump the default snapshot version to 0.4.0 in AndroidConfig. - Add the 0.4.0 CHANGELOG entry and a divider clarifying that FlashCat releases are versioned 0.x while the inherited upstream Datadog history is 3.x. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fiona2016
force-pushed
the
fix/optional-deps-cleanup
branch
from
e87d26b to
b843798
Compare
Fiona2016
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cleanup pass over the
compileOnlyoptional-dependency work landed sincev0.3.0, and version bump to 0.4.0 for release.Why 0.4.0 (not 0.3.1): the
compileOnlychange is breaking for integrators (apps must now provideokhttp/gsonthemselves), so a minor bump reflects the impact better than a patch.Changes
WorkManagerUtils.isInitialized(Context)is nowinternal, and the unusedgetWorkManagerOrNull(Context)helper is removed. Both were exported in the public API surface (apiSurface/dd-sdk-android-core.api); the baselines are regenerated accordingly.getWorkManagerOrNullhad no call sites.androidx.work.WorkManagerinProcessLifecycleCallbackandDatadogExceptionHandler(their only use,WorkManager.isInitialized(), was replaced by the context-aware helper).Log.einstead of a fully-qualified call inDatadog; translate theWorkManagerUtilscomments to English; add a trailing newline.0.4.0inAndroidConfig.0.4.0entry (documents thecompileOnlybreaking change, WorkManager-optional behavior, and new no-op modules), plus a divider clarifying that FlashCat releases are versioned0.xwhile the inherited upstream Datadog history is3.x.Verification
:dd-sdk-android-core:compileReleaseKotlin— passes (forced recompile).:dd-sdk-android-core:apiDump— regenerated baselines match the hand-edited files exactly (zero churn); leaked symbols confirmed gone.🤖 Generated with Claude Code