feat: add gpu index for nvidia-smi input#1446
Open
LeeZBug wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GPU index label to the nvidia_smi input’s emitted metrics so GPUs can be identified by both UUID and their nvidia-smi index.
Changes:
- Adds
indexas a query field constant and includes it in the required query fields list. - Reads the GPU
indexfrom the scrape results and attaches it togpu_infoand per-field metric samples.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inputs/nvidia_smi/types.go | Adds indexQField to requiredFields so it’s included in scrapes. |
| inputs/nvidia_smi/fields.go | Introduces the indexQField constant. |
| inputs/nvidia_smi/nvidia_smi.go | Attaches index label to gpu_info and all parsed metric samples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
109
to
+111
| } | ||
|
|
||
| slist.PushFront(types.NewSample(inputName, metricInfo.metricName, num, map[string]string{"uuid": uuid})) | ||
| slist.PushFront(types.NewSample(inputName, metricInfo.metricName, num, map[string]string{"uuid": uuid, "index": index})) |
Comment on lines
25
to
28
| requiredFields = []qField{ | ||
| uuidQField, | ||
| indexQField, | ||
| nameQField, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scraping configuration with nvidia-smi, it was found that the GPU index was missing. This commit adds an index label to the metric labels.