-
Notifications
You must be signed in to change notification settings - Fork 13
Add CI #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add CI #90
Conversation
|
|
||
| - name: Install tools | ||
| run: | | ||
| sudo apt-get update && sudo apt-get install -y debian-archive-keyring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be handled by Nix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know how to do this?
I tried adding to the Flake.nix but it didn't work:
Line 61 in 054adc1
| debian-archive-keyring |
| - name: Generate SHA256 checksums | ||
| run: | | ||
| cd build/ | ||
| TIMESTAMP=$(git show -s --format=%ct HEAD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be visually easier to have a human-readable timestamp here
| steps: | ||
| - name: Validate images | ||
| id: set-matrix | ||
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this could have been a Python script for a much easier strings manipulation
This CI adds a simple workflow to build mkosi images.
By default, it runs on every push to main, but it can also be triggered on a custom branch.
It is suited for
bob-l1andbob-l2images (even thoughbob-l2it's not on main right now :P).There is definitely room for improvement, but it’s a good starting point.
Possible improvements:
bob-l1andbob-l2are built in parallel right now but it could make sense to build them sequentially)trunk/buildernetTest run on my fork: https://github.com/endlesschains/flashbots-images/actions/runs/21524492215