Skip to content

Conversation

@canercidam
Copy link
Collaborator

No description provided.

@claude
Copy link
Contributor

claude bot commented Feb 12, 2026

Claude finished @canercidam's task in 42s —— View job


PR Review: Fix build version injection

  • Analyze PR diff and changed files
  • Review .goreleaser.yaml in full context
  • Check how version/build info is used in the codebase
  • Post review feedback

Summary

This PR adds the -X main.version={{ .Version }} ldflag to all four goreleaser build targets. Previously, the two darwin builds (darwin-amd64, darwin-arm64) had no ldflags section at all, and the two linux builds (linux-amd64, linux-arm64) had ldflags for the static linker flags but were missing the version injection. As a result, builder-playground version would always print dev for release builds.

The fix correctly targets main.version (main.go:25) which is used by the version command (main.go:504-510).

No issues found. The change is minimal, correct, and consistent across all build targets. LGTM.

@canercidam canercidam merged commit b0fcdda into main Feb 13, 2026
14 checks passed
@canercidam canercidam deleted the caner/fix-build-version-injection branch February 13, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants