permission summary show access token person#1874
Merged
Conversation
Benchstat (RLS)Base: 📊 4 minor regression(s) (all within 5% threshold)
✅ 2 improvement(s)
Full benchstat output |
Benchstat (Other)Base: ✅ 2 improvement(s)
Full benchstat output |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
views/046_permission_subjects.sql (1)
35-37: Line 37 seems over-restrictive for this branch.
p.email IS NOT NULLfilters rows, but this branch always outputsNULL AS "email"(Line 30). Consider removing the filter unless email presence is an explicit business rule foraccess_token_person.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@views/046_permission_subjects.sql` around lines 35 - 37, The WHERE clause currently includes "p.email IS NOT NULL" which conflicts with the branch that emits "NULL AS \"email\"" for access_token records (p.type = 'access_token'); remove this predicate or make it conditional so it doesn't filter out access_token rows — e.g., replace the filter with "AND (p.type != 'access_token' OR p.email IS NOT NULL)" or simply delete "p.email IS NOT NULL" so access_token_person rows (NULL AS \"email\") are retained; update the WHERE that references p.type and p.email accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@views/046_permission_subjects.sql`:
- Around line 27-34: The view is using p.id for the subject id which can collide
when a person has multiple access_tokens; change the subject id to use
access_tokens.id (e.g., replace p.id::TEXT AS id with access_tokens.id::TEXT AS
id) so each 'access_token_person' row is uniquely identified by the token's id
while keeping access_tokens.name, 'access_token_person' AS type, NULL AS
"email", and access_tokens.created_by::TEXT AS "owner" and the same INNER JOIN
between people and access_tokens intact.
---
Nitpick comments:
In `@views/046_permission_subjects.sql`:
- Around line 35-37: The WHERE clause currently includes "p.email IS NOT NULL"
which conflicts with the branch that emits "NULL AS \"email\"" for access_token
records (p.type = 'access_token'); remove this predicate or make it conditional
so it doesn't filter out access_token rows — e.g., replace the filter with "AND
(p.type != 'access_token' OR p.email IS NOT NULL)" or simply delete "p.email IS
NOT NULL" so access_token_person rows (NULL AS \"email\") are retained; update
the WHERE that references p.type and p.email accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 917800d6-f0d4-4c31-8992-e3316960eba0
📒 Files selected for processing (1)
views/046_permission_subjects.sql
adityathebe
force-pushed
the
feat/permission-summary-token
branch
from
6a69b62 to
80589f8
Compare
adityathebe
force-pushed
the
feat/permission-summary-token
branch
from
80589f8 to
1b0ed22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit